linux-kernel - Re: [PATCH v3 1/3] gpio: gpio-regmap: add flags to control some behaviour

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ee82305-6f46-461b-ad0d-441425727be3@orca.pet>
Date: Fri, 22 Aug 2025 13:04:32 +0200
From: Marcos Del Sol Vives <marcos@...a.pet>
To: Michael Walle <mwalle@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>
Cc: linux-kernel@...r.kernel.org, Bartosz Golaszewski <brgl@...ev.pl>,
 Lee Jones <lee@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
 linux-gpio@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH v3 1/3] gpio: gpio-regmap: add flags to control some
 behaviour

El 22/08/2025 a las 9:07, Michael Walle escribió:
>>> +       ret = gpio_regmap_set(chip, offset, value);
>>> +       if (ret)
>>> +               return ret;
> 
> Could you add a short paragraph to the commit message that you've
> added error checking? Something like:
> 
>   While at it, add the missing error check in
>   gpio_regmap_direction_output().
> 

Added! Thanks for the feedback!