lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4jklfoinsr7ldw5gn66kmfh4vwl7hqrhvnodakirsd5vx4uzqe@axhf5e7ei5g2>
Date: Fri, 22 Aug 2025 14:21:16 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
Cc: broonie@...nel.org, perex@...ex.cz, tiwai@...e.com, srini@...nel.org,
        lgirdwood@...il.com, linux-sound@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        krzysztof.kozlowski@...aro.org, neil.armstrong@...aro.org
Subject: Re: [PATCH v2 3/8] ASoC: codecs: wcd-common: move WCD_SDW_CH to
 common

On Fri, Aug 22, 2025 at 11:49:22AM +0100, Srinivas Kandagatla wrote:
> sdw_ch_info and WCD_SDW_CH macro is duplicated across wcd937x, wcd938x,
> wcd939x soundwire codec drivers. Move this to wcd common driver to
> remove this code duplication.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
> ---
>  sound/soc/codecs/wcd-common.h  | 11 +++++++++++
>  sound/soc/codecs/wcd937x-sdw.c |  4 ++--
>  sound/soc/codecs/wcd937x.h     | 16 ++--------------
>  sound/soc/codecs/wcd938x-sdw.c |  4 ++--
>  sound/soc/codecs/wcd938x.c     |  2 +-
>  sound/soc/codecs/wcd938x.h     | 13 +------------
>  sound/soc/codecs/wcd939x-sdw.c |  4 ++--
>  sound/soc/codecs/wcd939x.c     |  2 +-
>  sound/soc/codecs/wcd939x.h     | 13 +------------
>  9 files changed, 23 insertions(+), 46 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>


-- 
With best wishes
Dmitry

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ