linux-kernel - RE: [PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance control capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM3PPF208195D8D635C72DC9769044D0850E33CA@DM3PPF208195D8D.namprd11.prod.outlook.com>
Date: Sat, 23 Aug 2025 12:47:04 +0000
From: "Kandpal, Suraj" <suraj.kandpal@...el.com>
To: "Aaron, Ma" <aaron.ma@...onical.com>, "jani.nikula@...ux.intel.com"
	<jani.nikula@...ux.intel.com>, "Vivi, Rodrigo" <rodrigo.vivi@...el.com>,
	"joonas.lahtinen@...ux.intel.com" <joonas.lahtinen@...ux.intel.com>,
	"tursulin@...ulin.net" <tursulin@...ulin.net>, "airlied@...il.com"
	<airlied@...il.com>, "simona@...ll.ch" <simona@...ll.ch>,
	"intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
	"intel-xe@...ts.freedesktop.org" <intel-xe@...ts.freedesktop.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance
 control capability

> Subject: [PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance
> control capability
> 
> The VESA AUX backlight failed to be enabled becaused luminance_set is false
> always.
> Fix it by using luminance support control capabitliy.
> 
> Fixes: e13af5166a359 ("drm/i915/backlight: Use drm helper to initialize edp
> backlight")
> Signed-off-by: Aaron Ma <aaron.ma@...onical.com>

LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@...el.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index 41228478b21c7..0a3a3f6a5f9d8 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -546,7 +546,7 @@ static int intel_dp_aux_vesa_setup_backlight(struct
> intel_connector *connector,
>  				     luminance_range->max_luminance,
>  				     panel->vbt.backlight.pwm_freq_hz,
>  				     intel_dp->edp_dpcd, &current_level,
> &current_mode,
> -				     false);
> +				     panel-
> >backlight.edp.vesa.luminance_control_support);
>  	if (ret < 0)
>  		return ret;
> 
> --
> 2.43.0