linux-kernel - RE: [PATCH v2 05/12] media: imx-mipi-csis: Move clk to mipi_csis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00e501dc142f$6fa00a10$4ee01e30$@samsung.com>
Date: Sat, 23 Aug 2025 18:41:23 +0530
From: "Inbaraj E" <inbaraj.e@...sung.com>
To: "'Laurent Pinchart'" <laurent.pinchart@...asonboard.com>
Cc: <mturquette@...libre.com>, <sboyd@...nel.org>, <robh@...nel.org>,
	<krzk+dt@...nel.org>, <conor+dt@...nel.org>, <krzk@...nel.org>,
	<s.nawrocki@...sung.com>, <s.hauer@...gutronix.de>, <shawnguo@...nel.org>,
	<cw00.choi@...sung.com>, <rmfrfs@...il.com>, <martink@...teo.de>,
	<mchehab@...nel.org>, <linux-fsd@...la.com>, <will@...nel.org>,
	<catalin.marinas@....com>, <pankaj.dubey@...sung.com>,
	<shradha.t@...sung.com>, <ravi.patel@...sung.com>,
	<linux-clk@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <alim.akhtar@...sung.com>,
	<linux-samsung-soc@...r.kernel.org>, <kernel@...i.sm>,
	<kernel@...gutronix.de>, <festevam@...il.com>,
	<linux-media@...r.kernel.org>, <imx@...ts.linux.dev>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v2 05/12] media: imx-mipi-csis: Move clk to
 mipi_csis_info structure


Hi Laurent,

Thanks for the review.

> 
> On Thu, Aug 14, 2025 at 07:39:36PM +0530, Inbaraj E wrote:
> > clock names in NXP SoC's is different from the FSD SoC. Inorder to
> 
> s/clock/Clock/
> s/Inorder/In order/
> 
I'll change in next patchset.

> Is the difference really a matter of SoCs, or is it because the FSD SoC uses a
> different version of the IP ?
> 

Yes, it is dependent on the version of the IP.  Thanks for pointing it out. I'll update commit
description accordingly.

> I also suspect that the "phy" clock was added by mistake, and isn't needed in
> NXP SoCs. Could you please check and confirm if the v3.3 and
> v3.6.3 versions of the IP have an input PHY clock ?

I don't have manuals for v3.3 and v3.6.3, So I cannot confirm  this. 

> 
> > extend this driver to use for FSD SoC. Move the clock names to
> > mipi_csis_info structure.
> >

Regards,
Inbaraj E