linux-kernel - Re: [PATCH 1/3] riscv: dts: thead: th1520: add coefficients to the PVT node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6ac480db63aff3c59603db16e00b9c7b6580b663.camel@icenowy.me>
Date: Sat, 23 Aug 2025 22:37:13 +0800
From: Icenowy Zheng <uwu@...nowy.me>
To: Drew Fustini <fustini@...nel.org>
Cc: Guo Ren <guoren@...nel.org>, Fu Wei <wefu@...hat.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Han Gao <rabenda.cn@...il.com>, Yao Zi
 <ziyao@...root.org>,  linux-riscv@...ts.infradead.org,
 devicetree@...r.kernel.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] riscv: dts: thead: th1520: add coefficients to the
 PVT node

在 2025-08-22星期五的 14:29 -0700，Drew Fustini写道：
> On Sat, Aug 16, 2025 at 05:32:07PM +0800, Icenowy Zheng wrote:
> > The manual of TH1520 contains a set of coefficients a little
> > different
> > to the driver default ones.
> > 
> > Add them to the device tree node of PVT.
> > 
> > Signed-off-by: Icenowy Zheng <uwu@...nowy.me>
> > ---
> >  arch/riscv/boot/dts/thead/th1520.dtsi | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi
> > b/arch/riscv/boot/dts/thead/th1520.dtsi
> > index 03f1d73190499..e9c81bdabed8a 100644
> > --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> > @@ -676,6 +676,10 @@ pvt: pvt@...ff4e000 {
> >                         reg-names = "common", "ts", "pd", "vm";
> >                         clocks = <&aonsys_clk>;
> >                         #thermal-sensor-cells = <1>;
> > +                       moortec,ts-coeff-g = <42740>;
> > +                       moortec,ts-coeff-h = <220500>;
> > +                       moortec,ts-coeff-j = <(-160)>;
> > +                       moortec,ts-coeff-cal5 = <4094>;
> >                 };
> >  
> >                 gpio@...ff52000 {
> > -- 
> > 2.50.1
> > 
> 
> I think moortec,ts-coeff-XXX will need to be rounded to nearest
> multiple
> of 100 as dtbs_check warns that:
> 
> pvt@...ff4e000: moortec,ts-coeff-g: 42740 is not a multiple of 100
>         from schema $id:
> http://devicetree.org/schemas/hwmon/moortec,mr75203.yaml#
> pvt@...ff4e000: moortec,ts-coeff-j: -160 is not a multiple of 100
>         from schema $id:
> http://devicetree.org/schemas/hwmon/moortec,mr75203.yaml#
> pvt@...ff4e000: moortec,ts-coeff-g: 42740 is not a multiple of 100
>         from schema $id:
> http://devicetree.org/schemas/hwmon/moortec,mr75203.yaml#
> pvt@...ff4e000: moortec,ts-coeff-j: -160 is not a multiple of 100
>         from schema $id:
> http://devicetree.org/schemas/hwmon/moortec,mr75203.yaml#

Then it looks like the binding is to be blamed for not allowing fine
tweak.

> 
> Thanks,
> Drew