linux-kernel - Re: [PATCH v2 10/12] dt-bindings: media: fsd: Document CSIS DMA controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2eaa1303-79e6-431e-9902-356862357c9f@kernel.org>
Date: Sat, 23 Aug 2025 17:32:21 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Inbaraj E <inbaraj.e@...sung.com>, mturquette@...libre.com,
 sboyd@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 s.nawrocki@...sung.com, s.hauer@...gutronix.de, shawnguo@...nel.org,
 cw00.choi@...sung.com, rmfrfs@...il.com, laurent.pinchart@...asonboard.com,
 martink@...teo.de, mchehab@...nel.org, linux-fsd@...la.com, will@...nel.org,
 catalin.marinas@....com, pankaj.dubey@...sung.com, shradha.t@...sung.com,
 ravi.patel@...sung.com
Cc: linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, alim.akhtar@...sung.com,
 linux-samsung-soc@...r.kernel.org, kernel@...i.sm, kernel@...gutronix.de,
 festevam@...il.com, linux-media@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 10/12] dt-bindings: media: fsd: Document CSIS DMA
 controller

On 23/08/2025 04:39, Inbaraj E wrote:
> Hi Krzysztof,
> 
> Thanks for the review.
> 
>> On 14/08/2025 16:09, Inbaraj E wrote:
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +  - interrupts
>>> +  - clocks
>>> +  - clock-names
>>> +  - iommus
>>> +  - port
>>
>> Also, you miss here supplies (as required).
> 
> According to the HW design of FSD SoC, the control to manage CSIS power is given to
> a separate CPU where custom firmware runs. Therefore. The Linux side does not control
> the CSIS power supplies directly and are hence not included in the device tree.

Usually this still means you vote for enabling these resources, at least
for other vendors it is like that. Unless you want to say these are
essentially always on and CANNOT be disabled ever.

Best regards,
Krzysztof