linux-kernel - Re: [PATCH net] net: dsa: b53: fix ageing time for BCM53101

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOiHx=mnXYmSsYzHQYDAnBg6vKzo0oj07hbiCJBVBegDbv4NAQ@mail.gmail.com>
Date: Sat, 23 Aug 2025 18:00:25 +0200
From: Jonas Gorski <jonas.gorski@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>, Vladimir Oltean <olteanv@...il.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: b53: fix ageing time for BCM53101

On Sat, Aug 23, 2025 at 5:31 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Sat, Aug 23, 2025 at 05:27:02PM +0200, Jonas Gorski wrote:
> > Hi,
> >
> > On Sat, Aug 23, 2025 at 5:00 PM Andrew Lunn <andrew@...n.ch> wrote:
> > >
> > > On Sat, Aug 23, 2025 at 11:06:16AM +0200, Jonas Gorski wrote:
> > > > For some reason Broadcom decided that BCM53101 uses 0.5s increments for
> > > > the ageing time register, but kept the field width the same [1]. Due to
> > > > this, the actual ageing time was always half of what was configured.
> > > >
> > > > Fix this by adapting the limits and value calculation for BCM53101.
> > > >
> > > > [1] https://github.com/Broadcom-Network-Switching-Software/OpenMDK/blob/master/cdk/PKG/chip/bcm53101/bcm53101_a0_defs.h#L28966
> > >
> > > Is line 28966 correct? In order to find a reference to age, i needed
> > > to search further in the file.
> >
> > Hm, indeed, it's #30768. Not sure where that original line came from,
> > maybe I miss-clicked before copying the link in the address bar.
>
> Or a new version has been dumped there, changing all the line numbers?
> I've not looked, is there a tag you can use instead of master?

Uh, indeed the repository was updated. I didn't expect that, since its
was unchanged since its creation in 2020 with a single commit, so I
assumed Broadcom abandoned it like they did with a lot of other
repositories, and treated it as a static code dump.

Though they force pushed a new master. Well, "new". master is now
v2.10.9, and was previously v2.11.0. Don't ask me. But at least they
also added tags for the two versions.

So https://github.com/Broadcom/OpenMDK/blob/v2.11.0/cdk/PKG/chip/bcm53101/bcm53101_a0_defs.h#L28966
is what the link should now be (they also moved the repository).

That's not the first time I saw Broadcom force pushing to a public
(SDK) repository, so that link might also break eventually anyway.

Best regards,
Jonas