linux-kernel - Re: [PATCH 08/14] dt-bindings: dma: dma350: Document interrupt-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eda79403-375b-4d49-9fec-12bc98bf9e47@kernel.org>
Date: Sat, 23 Aug 2025 18:09:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jisheng Zhang <jszhang@...nel.org>, Vinod Koul <vkoul@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Robin Murphy <robin.murphy@....com>
Cc: dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/14] dt-bindings: dma: dma350: Document interrupt-names

On 23/08/2025 17:40, Jisheng Zhang wrote:
> Currently, the dma350 driver assumes all channels are available to
> linux, this may not be true on some platforms, so it's possible no
> irq(s) for the unavailable channel(s). What's more, the available
> channels may not be continuous. To handle this case, we'd better
> get the irq of each channel by name.

You did not solve the actual problem - binding still lists the
interrupts in specific order.

> 
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> ---
>  Documentation/devicetree/bindings/dma/arm,dma-350.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/arm,dma-350.yaml b/Documentation/devicetree/bindings/dma/arm,dma-350.yaml
> index 429f682f15d8..94752516e51a 100644
> --- a/Documentation/devicetree/bindings/dma/arm,dma-350.yaml
> +++ b/Documentation/devicetree/bindings/dma/arm,dma-350.yaml
> @@ -32,6 +32,10 @@ properties:
>        - description: Channel 6 interrupt
>        - description: Channel 7 interrupt
>  
> +  interrupt-names:
> +    minItems: 1
> +    maxItems: 8

You need to list the items.


> +
>    "#dma-cells":
>      const: 1
>      description: The cell is the trigger input number
> @@ -40,5 +44,6 @@ required:
>    - compatible
>    - reg
>    - interrupts
> +  - interrupt-names

That's ABI break, so no.



Best regards,
Krzysztof