linux-kernel - Re: [PATCH net v2] net: dlink: fix multicast stats being counted incorrectly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DC9Y9ZQA78BC.34TLXL2P7VT3T@gmail.com>
Date: Sun, 24 Aug 2025 01:33:11 +0900
From: "Yeounsu Moon" <yyyynoom@...il.com>
To: "Andrew Lunn" <andrew@...n.ch>
Cc: "Andrew Lunn" <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, "Eric Dumazet" <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, "Paolo Abeni" <pabeni@...hat.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v2] net: dlink: fix multicast stats being counted
 incorrectly

On Sat Aug 23, 2025 at 12:15 AM KST, Andrew Lunn wrote:
> The hash for fixes tends to be shorter than that.
>
> Fixes: 3401299a1b9e ("de6*/dl2k/sundance: Move the D-Link drivers")
>
> If you add this to your .git/config
>
> [pretty]
>         fixes = Fixes: %h (\"%s\")
>
> You can do
>
> git log --pretty=fixes 3401299a1b9e747cbf7de2cc0c8f6376c3cbe565
> Fixes: 3401299a1b9e ("de6*/dl2k/sundance: Move the D-Link drivers")
>
Thanks for pointing that out.

> This problem actually goes back further:
>
> git blame 3401299a1b9e~1 drivers/net/dl2k.c
>
> shows it was broken in the first commit in git.
>
> So the correct Fixes: tag is:
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>
Regarding the Fixes: tag, I have one question. You suggested
1da177e4c3f4 ("Linux-2.6.12-rc2"), which is indeed the first commit in
the current git history. However, the actual code change seems to go
back further, and I found it in the history.git repository.

In such cases, should the Fixes: tag refer to the first commit in the
mailine git tree, or to the actual commit in history.git where the bug
originated?