linux-kernel - Re: [PATCH v4 2/3] gpio: vortex: add new GPIO device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250824074243.416291-1-wbg@kernel.org>
Date: Sun, 24 Aug 2025 16:42:39 +0900
From: William Breathitt Gray <wbg@...nel.org>
To: Marcos Del Sol Vives <marcos@...a.pet>
Cc: William Breathitt Gray <wbg@...nel.org>,
	linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Michael Walle <mwalle@...nel.org>,
	Lee Jones <lee@...nel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-gpio@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH v4 2/3] gpio: vortex: add new GPIO device driver

On Fri, Aug 22, 2025 at 03:58:12PM +0200, Marcos Del Sol Vives wrote:
> Add a new simple GPIO device driver for most DM&P Vortex86 SoCs,
> implemented according to their programming reference manuals [1][2][3].
> 
> Vortex86EX/EX2 use a radically different mechanism of GPIO control
> and are not supported by this driver.
> 
> This is required for detecting the status of the poweroff button and
> performing the poweroff sequence on ICOP eBox computers.
> 
> IRQs are not implemented, as they are only available for ports 0 and 1,
> none which are accessible on my test machine (an EBOX-3352-GLW).
> 
> [1]: https://www.vortex86.com/downloadsStart?serial=Vortex86SX/DX/MXPLUS
> [2]: https://www.vortex86.com/downloadsStart?serial=Vortex86DX2
> [3]: https://www.vortex86.com/downloadsStart?serial=Vortex86DX3
> 
> Signed-off-by: Marcos Del Sol Vives <marcos@...a.pet>

Hi Marcos,

Thank you for taking the time to develop and improve this driver. It can
be intimidating to submit patches and interface changes for public
review (especially without the help of the hardware company), so I
commend your continual efforts.

Regarding this GPIO driver, you've incorporated much of what I had
intended to comment on for your v2, so I'm comfortable leaving an Ack
for this version here.

Acked-by: William Breathitt Gray <wbg@...nel.org>

However, I do have a couple minor suggestions below if you decide to
submit a v5.

> +VORTEX HARDWARE SUPPORT
> +R:	Marcos Del Sol Vives <marcos@...a.pet>
> +S:	Maintained
> +F:	drivers/gpio/gpio-vortex.c

This driver only covers GPIO support so a better title for this
MAINTAINERS entry would be "VORTEX86 GPIO SUPPORT".

> +	rmcfg.reg_bits = 8;
> +	rmcfg.val_bits = 8;
> +	rmcfg.io_port = true;
> +	rmcfg.wr_table = &priv->access_table;
> +	rmcfg.rd_table = &priv->access_table;

The direction ports are expected to hold their previous state until they
are changed, so perhaps it would be beneficial to enable caching with a
rmcfg.cache_type = REGCACHE_FLAT and set a volatile_table which
excludes the data port range.

William Breathitt Gray