linux-kernel - [PATCH v9 0/3] scsi: sd: Cleanups and warning fixes in sd_revalidate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250824180218.39498-1-abinashsinghlalotra@gmail.com>
Date: Sun, 24 Aug 2025 23:32:15 +0530
From: Abinash Singh <abinashsinghlalotra@...il.com>
To: bvanassche@....org
Cc: James.Bottomley@...senPartnership.com,
	abinashsinghlalotra@...il.com,
	dlemoal@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org,
	martin.petersen@...cle.com
Subject: [PATCH v9 0/3] scsi: sd: Cleanups and warning fixes in sd_revalidate_disk()

Hi all,

Sorry for making mess in previous replies. My gmail app caused that.


This v9 series contains small cleanups and fixes in sd_revalidate_disk().

On Sat, Aug 23, 2025 at 1:17 AM Bart Van Assche wrote:
> From Documentation/process/coding-style.rst:
> These generic allocation functions all emit a stack dump on failure when
> used without __GFP_NOWARN so there is no use in emitting an additional
> failure message when NULL is returned.
>
> Has this example perhaps been followed? I think it is safe to remove
> this sd_printk() statement.

checkpatch.pl also emits the following warning for this code:
  WARNING: Possible unnecessary 'out of memory' message
  #52: FILE: drivers/scsi/sd.c:3716:
  + if (!lim) {
  +     sd_printk(KERN_WARNING, sdkp,

So I agree with Bart — this printk is redundant and should be removed.
In v9, I have split this into a separate patch for clarity.

Summary of changes in this series:
  Removed  the redundant 'out of memory' printk after kmalloc() failure in already existing code.
>     buffer = kmalloc(SD_BUF_SIZE, GFP_KERNEL);
>     if (!buffer) {
>              sd_printk(KERN_WARNING, sdkp, "sd_revalidate_disk: Memory "

  Added Bart Van Assche’s Reviewed-by tag in: [3/3] scsi: sd: make sd_revalidate_disk() return void

Changes since v8:
  - Split removal of the redundant printk into its own patch (1/3),
    instead of keeping it inside the warning fix.
  - Kept the build warning fix and return type change as separate patches.
  - Updated changelogs accordingly.

Thanks

Abinash

Abinash Singh (3):
  scsi: sd: Remove redundant printk after kmalloc failure
  scsi: sd: Fix build warning in sd_revalidate_disk()
  scsi: sd: make sd_revalidate_disk() return void

 drivers/scsi/sd.c | 58 ++++++++++++++++++++++++-----------------------
 1 file changed, 30 insertions(+), 28 deletions(-)

-- 
2.43.0