linux-kernel - Re: [PATCH] w1: matrox: Remove some deadcode in matrox_w1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4c9660b2-879a-4bc1-adeb-9056da364ae7@kernel.org>
Date: Sun, 24 Aug 2025 18:56:14 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] w1: matrox: Remove some deadcode in matrox_w1_remove()

On 21/08/2025 12:02, Christophe JAILLET wrote:
> The .remove function can only be called if the .probe() succeeds. So there
> is no need to keep track of a successful probe in 'found'.
> 
> Simplify code accordingly.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only
> ---
>  drivers/w1/masters/matrox_w1.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/w1/masters/matrox_w1.c b/drivers/w1/masters/matrox_w1.c
> index 2852cd2dc67c..146fa7c6e74e 100644
> --- a/drivers/w1/masters/matrox_w1.c
> +++ b/drivers/w1/masters/matrox_w1.c
> @@ -47,7 +47,6 @@ struct matrox_device {
>  
>  	unsigned long phys_addr;
>  	void __iomem *virt_addr;
> -	unsigned long found;
>  
>  	struct w1_bus_master *bus_master;
>  };
> @@ -158,8 +157,6 @@ static int matrox_w1_probe(struct pci_dev *pdev, const struct pci_device_id *ent
>  
>  	pci_set_drvdata(pdev, dev);
>  
> -	dev->found = 1;

What wonderful code was this... Good catch, I'll apply it soon.

Best regards,
Krzysztof