linux-kernel - Re: [PATCH 19/65] media: camss: Replace .open() file operation with v4l2_fh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb733991-857c-4a5b-ba20-d8bd557a4339@linaro.org>
Date: Sun, 24 Aug 2025 22:04:45 +0300
From: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
To: Jacopo Mondi <jacopo.mondi@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Devarsh Thakkar
 <devarsht@...com>, Benoit Parrot <bparrot@...com>,
 Hans Verkuil <hverkuil@...nel.org>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Hans de Goede <hansg@...nel.org>,
 Parthiban Veerasooran <parthiban.veerasooran@...rochip.com>,
 Christian Gromm <christian.gromm@...rochip.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Alex Shi
 <alexs@...nel.org>, Yanteng Si <si.yanteng@...ux.dev>,
 Jonathan Corbet <corbet@....net>, Tomasz Figa <tfiga@...omium.org>,
 Marek Szyprowski <m.szyprowski@...sung.com>,
 Andy Walls <awalls@...metrocast.net>,
 Michael Tretter <m.tretter@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Bin Liu <bin.liu@...iatek.com>, Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Dmitry Osipenko <digetx@...il.com>, Thierry Reding
 <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>,
 Mirela Rabulea <mirela.rabulea@....com>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
 Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
 Michal Simek <michal.simek@....com>, Ming Qian <ming.qian@....com>,
 Zhou Peng <eagle.zhou@....com>, Xavier Roumegue
 <xavier.roumegue@....nxp.com>, Philipp Zabel <p.zabel@...gutronix.de>,
 Vikash Garodia <quic_vgarodia@...cinc.com>,
 Dikshita Agarwal <quic_dikshita@...cinc.com>,
 Abhinav Kumar <abhinav.kumar@...ux.dev>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Sylwester Nawrocki <sylvester.nawrocki@...il.com>,
 Jernej Skrabec <jernej.skrabec@...il.com>, Chen-Yu Tsai <wens@...e.org>,
 Samuel Holland <samuel@...lland.org>,
 Daniel Almeida <daniel.almeida@...labora.com>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 Minghsiu Tsai <minghsiu.tsai@...iatek.com>,
 Houlong Wei <houlong.wei@...iatek.com>,
 Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
 Tiffany Lin <tiffany.lin@...iatek.com>,
 Yunfei Dong <yunfei.dong@...iatek.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Magnus Damm <magnus.damm@...il.com>,
 Mikhail Ulyanov <mikhail.ulyanov@...entembedded.com>,
 Jacob Chen <jacob-chen@...wrt.com>, Heiko Stuebner <heiko@...ech.de>,
 Detlev Casanova <detlev.casanova@...labora.com>,
 Krzysztof Kozlowski <krzk@...nel.org>,
 Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Łukasz Stelmach <l.stelmach@...sung.com>,
 Andrzej Pietrasiewicz <andrzejtp2010@...il.com>,
 Jacek Anaszewski <jacek.anaszewski@...il.com>,
 Andrzej Hajda <andrzej.hajda@...el.com>,
 Fabien Dessenne <fabien.dessenne@...s.st.com>,
 Jean-Christophe Trotin <jean-christophe.trotin@...s.st.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Nicolas Dufresne <nicolas.dufresne@...labora.com>,
 Benjamin Gaignard <benjamin.gaignard@...labora.com>,
 Steve Longerbeam <slongerbeam@...il.com>, Maxime Ripard
 <mripard@...nel.org>, Paul Kocialkowski <paulk@...-base.io>,
 Niklas Söderlund <niklas.soderlund@...natech.se>,
 Robert Foss <rfoss@...nel.org>, Todor Tomov <todor.too@...il.com>,
 Corentin Labbe <clabbe@...libre.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-staging@...ts.linux.dev, linux-doc@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 linux-tegra@...r.kernel.org, imx@...ts.linux.dev,
 linux-renesas-soc@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-samsung-soc@...r.kernel.org, linux-sunxi@...ts.linux.dev,
 linux-usb@...r.kernel.org, linux-amlogic@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org,
 linux-stm32@...md-mailman.stormreply.com, mjpeg-users@...ts.sourceforge.net
Subject: Re: [PATCH 19/65] media: camss: Replace .open() file operation with
 v4l2_fh_open()

Hi Jacopo, Laurent,

thank you for the nice clean-up.

On 8/2/25 12:22, Jacopo Mondi wrote:
> From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
> The custom video_open() function in the camss driver open-codes the
> v4l2_fh_open() helper, with an additional mutex that protects the whole
> function. Given that the function does not modify any data guarded by
> the lock, there's no need for using the mutex and the function can be
> replaced by v4l2_fh_open().
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo.mondi@...asonboard.com>

Tested-by: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>

-- 
Best wishes,
Vladimir