linux-kernel - Re: [PATCH net-next v6 3/3] net: dsa: yt921x: Add support for Motorcomm YT921x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34f10173-0f88-43cf-81e6-744c73489574@lunn.ch>
Date: Sun, 24 Aug 2025 21:16:06 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Yangfl <mmyangfl@...il.com>, netdev@...r.kernel.org,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Simon Horman <horms@...nel.org>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v6 3/3] net: dsa: yt921x: Add support for
 Motorcomm YT921x

> > They are locked wrappers for their unlocked counterparts. I'd like to
> > name the unlocked versions __yt921x_smi_read just like __mdiobus_read,
> > but that was turned down in the previous version, so I have to give
> > the locked versions a stranger marker since we use unlocked versions
> > more often.
> 
> Who turned it down, and what reason did they give, given that it's an
> established pattern in the phylib, mdiobus and mdiodev APIs.

I did. In general, DSA drivers don't use __ for their own functions,
but there are exceptions.

I also think this will all go away once the current problems with
locking in this driver are solved.

	Andrew