lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aKxrYlx1Rzvp8ebO@localhost.localdomain>
Date: Mon, 25 Aug 2025 15:55:46 +0200
From: Frederic Weisbecker <frederic@...nel.org>
To: Marco Crivellari <marco.crivellari@...e.com>
Cc: linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	Lai Jiangshan <jiangshanlai@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH v2 1/4] Workqueue: replace use of system_wq with
 system_percpu_wq

Le Mon, Aug 25, 2025 at 03:29:03PM +0200, Marco Crivellari a écrit :
> Currently if a user enqueue a work item using schedule_delayed_work() the
> used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
> WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
> schedule_work() that is using system_wq and queue_work(), that makes use
> again of WORK_CPU_UNBOUND.
> 
> This lack of consistentcy cannot be addressed without refactoring the API.
> 
> system_wq is a per-CPU worqueue, yet nothing in its name tells about that
> CPU affinity constraint, which is very often not required by users. Make
> it clear by adding a system_percpu_wq.
> 
> queue_work() / queue_delayed_work() mod_delayed_work() will now use the
> new per-cpu wq: whether the user still stick on the old name a warn will
> be printed along a wq redirect to the new one.
> 
> This patch add the new system_percpu_wq except for mm, fs and net
> subsystem, whom are handled in separated patches.
> 
> The old wq will be kept for a few release cylces.
> 
> Suggested-by: Tejun Heo <tj@...nel.org>
> Signed-off-by: Marco Crivellari <marco.crivellari@...e.com>
> ---
>  arch/s390/kernel/diag/diag324.c               |  4 ++--
>  arch/s390/kernel/hiperdispatch.c              |  2 +-
>  drivers/accel/ivpu/ivpu_hw_btrs.c             |  2 +-
>  drivers/accel/ivpu/ivpu_ipc.c                 |  2 +-
>  drivers/accel/ivpu/ivpu_job.c                 |  2 +-
>  drivers/accel/ivpu/ivpu_mmu.c                 |  2 +-
>  drivers/accel/ivpu/ivpu_pm.c                  |  2 +-
>  drivers/acpi/osl.c                            |  2 +-
>  drivers/base/devcoredump.c                    |  2 +-
>  drivers/block/nbd.c                           |  2 +-
>  drivers/block/sunvdc.c                        |  2 +-
>  drivers/cxl/pci.c                             |  2 +-
>  drivers/extcon/extcon-intel-int3496.c         |  4 ++--
>  drivers/gpio/gpiolib-cdev.c                   |  4 ++--
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |  4 ++--
>  drivers/gpu/drm/bridge/ite-it6505.c           |  2 +-
>  drivers/gpu/drm/bridge/ti-tfp410.c            |  2 +-
>  drivers/gpu/drm/drm_probe_helper.c            |  2 +-
>  drivers/gpu/drm/drm_self_refresh_helper.c     |  2 +-
>  drivers/gpu/drm/exynos/exynos_hdmi.c          |  2 +-
>  drivers/gpu/drm/i915/i915_driver.c            |  2 +-
>  drivers/gpu/drm/i915/i915_drv.h               |  2 +-
>  .../gpu/drm/rockchip/dw_hdmi_qp-rockchip.c    |  4 ++--
>  drivers/gpu/drm/scheduler/sched_main.c        |  2 +-
>  drivers/gpu/drm/tilcdc/tilcdc_crtc.c          |  2 +-
>  drivers/gpu/drm/vc4/vc4_hdmi.c                |  4 ++--
>  drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c   |  6 ++---
>  drivers/gpu/drm/xe/xe_pt.c                    |  2 +-
>  drivers/iio/adc/pac1934.c                     |  2 +-
>  drivers/input/keyboard/gpio_keys.c            |  2 +-
>  drivers/input/misc/palmas-pwrbutton.c         |  2 +-
>  drivers/input/mouse/synaptics_i2c.c           |  8 +++----
>  drivers/leds/trigger/ledtrig-input-events.c   |  2 +-
>  drivers/md/bcache/super.c                     | 20 ++++++++---------
>  drivers/mmc/host/mtk-sd.c                     |  4 ++--
>  drivers/net/ethernet/sfc/efx_channels.c       |  2 +-
>  drivers/net/ethernet/sfc/siena/efx_channels.c |  2 +-
>  drivers/net/phy/sfp.c                         | 12 +++++-----
>  drivers/net/wireless/intel/ipw2x00/ipw2100.c  |  6 ++---
>  drivers/net/wireless/intel/ipw2x00/ipw2200.c  |  2 +-
>  drivers/net/wireless/intel/iwlwifi/mvm/tdls.c |  6 ++---
>  .../net/wireless/mediatek/mt76/mt7921/init.c  |  2 +-
>  .../net/wireless/mediatek/mt76/mt7925/init.c  |  2 +-
>  drivers/nvdimm/security.c                     |  4 ++--
>  drivers/nvme/target/admin-cmd.c               |  2 +-
>  drivers/nvme/target/fabrics-cmd-auth.c        |  2 +-
>  drivers/pci/endpoint/pci-ep-cfs.c             |  2 +-
>  drivers/phy/allwinner/phy-sun4i-usb.c         | 14 ++++++------
>  .../platform/cznic/turris-omnia-mcu-gpio.c    |  2 +-
>  .../surface/aggregator/ssh_packet_layer.c     |  2 +-
>  .../surface/aggregator/ssh_request_layer.c    |  2 +-
>  drivers/platform/x86/gpd-pocket-fan.c         |  4 ++--
>  .../x86/x86-android-tablets/vexia_atla10_ec.c |  2 +-
>  drivers/power/supply/bq2415x_charger.c        |  2 +-
>  drivers/power/supply/bq24190_charger.c        |  2 +-
>  drivers/power/supply/bq27xxx_battery.c        |  6 ++---
>  drivers/power/supply/rk817_charger.c          |  6 ++---
>  drivers/power/supply/ucs1002_power.c          |  2 +-
>  drivers/power/supply/ug3105_battery.c         |  6 ++---
>  drivers/ras/cec.c                             |  2 +-
>  drivers/regulator/irq_helpers.c               |  2 +-
>  drivers/regulator/qcom-labibb-regulator.c     |  4 ++--
>  drivers/thunderbolt/tb.c                      |  2 +-
>  drivers/usb/dwc3/gadget.c                     |  2 +-
>  drivers/usb/host/xhci-dbgcap.c                |  8 +++----
>  drivers/usb/host/xhci-ring.c                  |  2 +-
>  drivers/xen/events/events_base.c              |  6 ++---
>  include/drm/gpu_scheduler.h                   |  2 +-
>  include/linux/closure.h                       |  2 +-
>  include/linux/workqueue.h                     | 22 +++++++++----------
>  io_uring/io_uring.c                           |  2 +-
>  kernel/bpf/cgroup.c                           |  2 +-
>  kernel/bpf/cpumap.c                           |  2 +-
>  kernel/cgroup/cgroup.c                        |  2 +-
>  kernel/module/dups.c                          |  4 ++--
>  kernel/rcu/tasks.h                            |  4 ++--
>  kernel/smp.c                                  |  2 +-
>  kernel/trace/trace_events_user.c              |  2 +-
>  kernel/workqueue.c                            |  2 +-
>  rust/kernel/workqueue.rs                      |  6 ++---
>  sound/soc/codecs/aw88081.c                    |  2 +-
>  sound/soc/codecs/aw88166.c                    |  2 +-
>  sound/soc/codecs/aw88261.c                    |  2 +-
>  sound/soc/codecs/aw88395/aw88395.c            |  2 +-
>  sound/soc/codecs/aw88399.c                    |  2 +-
>  sound/soc/codecs/cs42l43-jack.c               |  6 ++---
>  sound/soc/codecs/cs42l43.c                    |  4 ++--
>  sound/soc/codecs/es8326.c                     | 12 +++++-----
>  sound/soc/codecs/rt5663.c                     |  6 ++---
>  sound/soc/intel/boards/sof_es8336.c           |  2 +-
>  sound/soc/sof/intel/cnl.c                     |  2 +-
>  sound/soc/sof/intel/hda-ipc.c                 |  2 +-

Similar cut needed here.

Thanks.

-- 
Frederic Weisbecker
SUSE Labs

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ