linux-kernel - Re: [PATCH RFC 1/3] dt-bindings: input: elan: Introduce Elan eKTP1059 Touchpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250825-decal-purchase-8cfe0003a3f2@spud>
Date: Mon, 25 Aug 2025 17:40:56 +0100
From: Conor Dooley <conor@...nel.org>
To: Andreas Kemnade <andreas@...nade.info>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Henrik Rydberg <rydberg@...math.org>,
	Tony Lindgren <tony@...mide.com>, hns@...delico.com,
	linux-input@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH RFC 1/3] dt-bindings: input: elan: Introduce Elan
 eKTP1059 Touchpad

On Mon, Aug 25, 2025 at 12:07:28AM +0200, Andreas Kemnade wrote:
> The Elan eKTP1059 Touchpad is seen in the Epson Moverio BT-200
> attached via SPI. Add a binding for this chip. Little is known.
> 
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> ---
>  .../devicetree/bindings/input/elan,ektp1059.yaml   | 45 ++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/elan,ektp1059.yaml b/Documentation/devicetree/bindings/input/elan,ektp1059.yaml
> new file mode 100644
> index 000000000000..a10256a271e0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/elan,ektp1059.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/elan,ektp1059.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Elantech SPI Touchpad
> +
> +maintainers:
> +  - Andreas Kemnade <andreas@...nade.info>
> +
> +allOf:
> +  - $ref: touchscreen/touchscreen.yaml#
> +
> +properties:
> +  compatible:
> +    const: elan,ektp1059
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false

Shouldn't this be unevalutedProperties: false, since you want to make
use of what's in touchscreen.yaml?

> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        touchpad@0 {
> +            compatible = "elan,ektp1059";
> +            reg = <0x0>;
> +            interrupt-parent = <&gpio4>;
> +            interrupts = <0x0 IRQ_TYPE_LEVEL_LOW>;
> +        };
> +    };
> 
> -- 
> 2.39.5
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)