linux-kernel - Re: [PATCH v1 0/5] drm: panel-backlight-quirks: Do partial refactor and apply OLED fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a24a7cd1-2281-4d98-8b68-a75e85c22dd5@amd.com>
Date: Mon, 25 Aug 2025 11:45:19 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Antheas Kapenekakis <lkml@...heas.dev>, amd-gfx@...ts.freedesktop.org
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 philm@...jaro.org, Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>
Subject: Re: [PATCH v1 0/5] drm: panel-backlight-quirks: Do partial refactor
 and apply OLED fix

On 8/24/2025 3:01 PM, Antheas Kapenekakis wrote:
> This is an alternative to [1], since Phil found out there are still invalid
> values. I made this series before the one I sent today, and I have to say
> I tested it much less. Because I did not think it was very viable to
> upstream. 

I'll look through and may leave some comments on individual patches.

But I do want to say because platforms can share panels or can have 
multiple sources we very likely should be keeping matching that does 
SMBIOS data and panel data together.

It's also completely feasible to launch another second source or third 
source panel later on which might not require the same quirks as the first.

Then lastly there are companies (IE Framework) that actively let people 
change out their panel for another.

>  I was also not aware of [2] and [3] since they are not in a
> public bug tracker such as amddrm and my issue there [4] remains closed.
> 
> I lower the cc'd here since this is a draft. 

You should make it "RFC".

> But this could have some
> viability. Especially since I can stop carrying the dodgy patches from
> SteamOS so that the SD OLED has a 0 brightness min.
> 
> [1] https://lore.kernel.org/all/20250824085351.454619-2-lkml@antheas.dev/
> [2] https://gitlab.manjaro.org/packages/core/linux616/-/blob/master/0001-drm-amd-display-Add-a-quirk-for-the-Zotac-Zone.patch
> [3] https://gitlab.manjaro.org/packages/core/linux616/-/blob/master/0004-TEMPORARY-terrible-hack-for-zotac-screen-while-debug.patch
> [4] https://gitlab.freedesktop.org/drm/amd/-/issues/3803
> 
> Antheas Kapenekakis (5):
>    drm: panel-backlight-quirks: Make ident optional
>    drm: panel-backlight-quirks: Convert brightness quirk to generic
>      structure
>    drm: panel-backlight-quirks: Add secondary DMI match
>    drm: panel-backlight-quirks: Add brightness mask quirk
>    drm: panel-backlight-quirks: Add Steam Decks
> 
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  19 +++-
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |   6 +
>   .../link/protocols/link_edp_panel_control.c   |   2 +-
>   drivers/gpu/drm/drm_panel_backlight_quirks.c  | 106 +++++++++++++-----
>   include/drm/drm_utils.h                       |   8 +-
>   5 files changed, 109 insertions(+), 32 deletions(-)
> 
> 
> base-commit: c17b750b3ad9f45f2b6f7e6f7f4679844244f0b9