linux-kernel - Re: [PATCH v2] ntb: Add mutex to make link_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e039337b-0bf7-4238-aa5e-21100a2646ac@deltatee.com>
Date: Mon, 25 Aug 2025 10:18:53 -0600
From: Logan Gunthorpe <logang@...tatee.com>
To: jdmason@...zu.us, dave.jiang@...el.com, allenbh@...il.com,
 ntb@...ts.linux.dev, linux-kernel@...r.kernel.org, fuyuanli0722@...il.com
Subject: Re: [PATCH v2] ntb: Add mutex to make link_event_callback executed
 linearly.

On 2025-08-25 03:15, fuyuanli wrote:
> Since the CPU selected by schedule_work is uncertain, multiple link_event
> callbacks may be executed at same time. For example, after peer's link is
> up, it is down quickly before local link_work completed. If link_cleanup
> is added to the workqueue of another CPU, then link_work and link_cleanup
> may be executed at the same time. So add a mutex to prevent them from being
> executed concurrently.
> 
> Signed-off-by: fuyuanli <fuyuanli@...iglobal.com>

Looks good to me, thanks

Reviewed-by: Logan Gunthorpe <logang@...tatee.com>