linux-kernel - Re: [PATCH net] net: macb: Disable clocks once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77d8a847-424e-4757-a703-709b6042236b@broadcom.com>
Date: Mon, 25 Aug 2025 10:08:25 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Sean Anderson <sean.anderson@...ux.dev>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Harini Katakam <harini.katakam@...inx.com>,
 Neil Mandir <neil.mandir@...o.com>, Claudiu Beznea
 <claudiu.beznea@...on.dev>,
 Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>,
 Nicolas Ferre <nicolas.ferre@...rochip.com>
Subject: Re: [PATCH net] net: macb: Disable clocks once

On 8/25/25 09:59, Sean Anderson wrote:
> From: Neil Mandir <neil.mandir@...o.com>
> 
> When the driver is removed the clocks are twice: once by the driver and a
> second time by runtime pm. Remove the redundant clock disabling. Disable
> wakeup so all the clocks are disabled. Always suspend the device as we
> always set it active in probe.

There is a missing word in that first sentence which I assume is "disabled".

> 
> Fixes: d54f89af6cc4 ("net: macb: Add pm runtime support")
> Signed-off-by: Neil Mandir <neil.mandir@...o.com>
> Co-developed-by: Sean Anderson <sean.anderson@...ux.dev>
> Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>
> ---
> 
>   drivers/net/ethernet/cadence/macb_main.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index ce95fad8cedd..8e9bfd0f040d 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -5403,14 +5403,11 @@ static void macb_remove(struct platform_device *pdev)
>   		mdiobus_free(bp->mii_bus);
>   
>   		unregister_netdev(dev);
> +		device_set_wakeup_enable(&bp->pdev->dev, 0);
>   		cancel_work_sync(&bp->hresp_err_bh_work);
>   		pm_runtime_disable(&pdev->dev);
>   		pm_runtime_dont_use_autosuspend(&pdev->dev);
> -		if (!pm_runtime_suspended(&pdev->dev)) {
> -			macb_clks_disable(bp->pclk, bp->hclk, bp->tx_clk,
> -					  bp->rx_clk, bp->tsu_clk);
> -			pm_runtime_set_suspended(&pdev->dev);
> -		}
> +		pm_runtime_set_suspended(&pdev->dev);
>   		phylink_destroy(bp->phylink);
>   		free_netdev(dev);
>   	}

-- 
Florian