linux-kernel - Re: [PATCH 2/2] drm: fix kernel-doc struct tag for `drm_modeset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABPJ0vh0VTdY4Mcso4m3224NZX01riSEBQng_=mvEZYgjgpBrA@mail.gmail.com>
Date: Mon, 25 Aug 2025 20:01:14 +0200
From: Giant Sand Fans <rampxxxx@...il.com>
To: Jani Nikula <jani.nikula@...ux.intel.com>
Cc: maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, 
	airlied@...il.com, simona@...ll.ch, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] drm: fix kernel-doc struct tag for `drm_modeset_lock`.

On Mon, 25 Aug 2025 at 10:00, Jani Nikula <jani.nikula@...ux.intel.com> wrote:
>
> On Sat, 23 Aug 2025, Javier Garcia <rampxxxx@...il.com> wrote:
> > - Add needed "@" to avoid warn messages about duplicated symbols
> > as there is function and struct with the same name.
> > - The fixed warning is:
> >
> >       ./Documentation/gpu/drm-kms:476: ./drivers/gpu/drm/drm_modeset_lock.c:377: WARNING: Duplicate C declaration, also defined at gpu/drm-kms:48.
> >       Declaration is '.. c:function:: int drm_modeset_lock (struct drm_modeset_lock *lock, struct drm_modeset_acquire_ctx *ctx)'. [duplicate_declaration.c]
>
> Please look into why adding @ here appear to fix the issue.
>
> The problem is deeper than what this patch makes it seem, and this
> papers over the issue in a way that sets the wrong example for the
> future.

Thank you for the comment, I'll look deeper into this.

>
>
> BR,
> Jani.
>
> >
> > Fixes: f3a808817fdb ("drm: fix drm_modeset_lock.h kernel-doc notation")
> > Signed-off-by: Javier Garcia <rampxxxx@...il.com>
> > ---
> >  include/drm/drm_modeset_lock.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/drm/drm_modeset_lock.h b/include/drm/drm_modeset_lock.h
> > index ec4f543c3d95..0de7046dc653 100644
> > --- a/include/drm/drm_modeset_lock.h
> > +++ b/include/drm/drm_modeset_lock.h
> > @@ -75,7 +75,7 @@ struct drm_modeset_acquire_ctx {
> >  };
> >
> >  /**
> > - * struct drm_modeset_lock - used for locking modeset resources.
> > + * @struct drm_modeset_lock - used for locking modeset resources.
> >   * @mutex: resource locking
> >   * @head: used to hold its place on &drm_atomi_state.locked list when
> >   *    part of an atomic update
>
> --
> Jani Nikula, Intel