linux-kernel - Re: [PATCH] x86/boot: clean up whitespace in a20.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50f68d28-beb4-4dab-b077-e9e2ba1ae9ee@zytor.com>
Date: Mon, 25 Aug 2025 11:01:32 -0700
From: Xin Li <xin@...or.com>
To: Harry Fellowes <harryfellowes1@...il.com>, x86@...nel.org
Cc: linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, dave.hansen@...ux.intel.com, hpa@...or.com
Subject: Re: [PATCH] x86/boot: clean up whitespace in a20.c

On 8/25/2025 10:46 AM, Harry Fellowes wrote:
> Remove trailing whitespace and fix blank lines in arch/x86/boot/a20.c
> reported by checkpatch.pl.
> 
> No functional changes.
> 
> Signed-off-by: Harry Fellowes <harryfellowes1@...il.com>
> ---
>   arch/x86/boot/a20.c | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/x86/boot/a20.c b/arch/x86/boot/a20.c
> index a2b6b428922a..15bbd4ac55cc 100644
> --- a/arch/x86/boot/a20.c
> +++ b/arch/x86/boot/a20.c
> @@ -135,29 +135,29 @@ int enable_a20(void)
>   		  (legacy free, etc.) */
>   	       if (a20_test_short())
>   		       return 0;
> -	
> +

This is good.

>   	       /* Next, try the BIOS (INT 0x15, AX=0x2401) */
>   	       enable_a20_bios();
>   	       if (a20_test_short())
>   		       return 0;
> -	
> -	       /* Try enabling A20 through the keyboard controller */
> +
> +/* Try enabling A20 through the keyboard controller */

Why?  We do tabs at the beginning.

>   	       kbc_err = empty_8042();
>   
>   	       if (a20_test_short())
>   		       return 0; /* BIOS worked, but with delayed reaction */
> -	
> -	       if (!kbc_err) {
> +
> +if (!kbc_err) {

...

>   		       enable_a20_kbc();
>   		       if (a20_test_long())
>   			       return 0;
>   	       }
> -	
> -	       /* Finally, try enabling the "fast A20 gate" */
> +
> +/* Finally, try enabling the "fast A20 gate" */

...

>   	       enable_a20_fast();
>   	       if (a20_test_long())
>   		       return 0;
>          }
> -
> -       return -1;
> +
> +return -1;

Fix one but then add four, not a good deal.


>   }