linux-kernel - Re: [patch V2 10/37] entry: Cleanup header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9209b7a-b882-416f-b04f-9991b02496e2@efficios.com>
Date: Mon, 25 Aug 2025 14:13:06 -0400
From: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To: Thomas Gleixner <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org>
Cc: Jens Axboe <axboe@...nel.dk>, Peter Zijlstra <peterz@...radead.org>,
 "Paul E. McKenney" <paulmck@...nel.org>, Boqun Feng <boqun.feng@...il.com>,
 Paolo Bonzini <pbonzini@...hat.com>, Sean Christopherson
 <seanjc@...gle.com>, Wei Liu <wei.liu@...nel.org>,
 Dexuan Cui <decui@...rosoft.com>, x86@...nel.org,
 Arnd Bergmann <arnd@...db.de>, Heiko Carstens <hca@...ux.ibm.com>,
 Christian Borntraeger <borntraeger@...ux.ibm.com>,
 Sven Schnelle <svens@...ux.ibm.com>, Huacai Chen <chenhuacai@...nel.org>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>
Subject: Re: [patch V2 10/37] entry: Cleanup header

On 2025-08-23 12:39, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@...utronix.de>
> 
> Cleanup the include ordering, kernel-doc and other trivialities before
> making further changes.

Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>

> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Peter Zijlstra <peterz@...radead.org>
> 
> ---
>   include/linux/entry-common.h     |    8 ++++----
>   include/linux/irq-entry-common.h |    2 ++
>   2 files changed, 6 insertions(+), 4 deletions(-)
> ---
> --- a/include/linux/entry-common.h
> +++ b/include/linux/entry-common.h
> @@ -3,11 +3,11 @@
>   #define __LINUX_ENTRYCOMMON_H
>   
>   #include <linux/irq-entry-common.h>
> +#include <linux/livepatch.h>
>   #include <linux/ptrace.h>
> +#include <linux/resume_user_mode.h>
>   #include <linux/seccomp.h>
>   #include <linux/sched.h>
> -#include <linux/livepatch.h>
> -#include <linux/resume_user_mode.h>
>   
>   #include <asm/entry-common.h>
>   #include <asm/syscall.h>
> @@ -37,6 +37,7 @@
>   				 SYSCALL_WORK_SYSCALL_AUDIT |		\
>   				 SYSCALL_WORK_SYSCALL_USER_DISPATCH |	\
>   				 ARCH_SYSCALL_WORK_ENTER)
> +
>   #define SYSCALL_WORK_EXIT	(SYSCALL_WORK_SYSCALL_TRACEPOINT |	\
>   				 SYSCALL_WORK_SYSCALL_TRACE |		\
>   				 SYSCALL_WORK_SYSCALL_AUDIT |		\
> @@ -61,8 +62,7 @@
>    */
>   void syscall_enter_from_user_mode_prepare(struct pt_regs *regs);
>   
> -long syscall_trace_enter(struct pt_regs *regs, long syscall,
> -			 unsigned long work);
> +long syscall_trace_enter(struct pt_regs *regs, long syscall, unsigned long work);
>   
>   /**
>    * syscall_enter_from_user_mode_work - Check and handle work before invoking
> --- a/include/linux/irq-entry-common.h
> +++ b/include/linux/irq-entry-common.h
> @@ -68,6 +68,7 @@ static __always_inline bool arch_in_rcu_
>   
>   /**
>    * enter_from_user_mode - Establish state when coming from user mode
> + * @regs:	Pointer to currents pt_regs
>    *
>    * Syscall/interrupt entry disables interrupts, but user mode is traced as
>    * interrupts enabled. Also with NO_HZ_FULL RCU might be idle.
> @@ -357,6 +358,7 @@ irqentry_state_t noinstr irqentry_enter(
>    * Conditional reschedule with additional sanity checks.
>    */
>   void raw_irqentry_exit_cond_resched(void);
> +
>   #ifdef CONFIG_PREEMPT_DYNAMIC
>   #if defined(CONFIG_HAVE_PREEMPT_DYNAMIC_CALL)
>   #define irqentry_exit_cond_resched_dynamic_enabled	raw_irqentry_exit_cond_resched
> 


-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com