linux-kernel - [PATCH v10 0/3] scsi: sd: Cleanups and warning fixes in sd_revalidate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250825183940.13211-1-abinashsinghlalotra@gmail.com>
Date: Tue, 26 Aug 2025 00:09:37 +0530
From: Abinash Singh <abinashsinghlalotra@...il.com>
To: bvanassche@....org
Cc: James.Bottomley@...senPartnership.com,
	abinashsinghlalotra@...il.com,
	dlemoal@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org,
	martin.petersen@...cle.com
Subject: [PATCH v10 0/3] scsi: sd: Cleanups and warning fixes in sd_revalidate_disk()


Hi all,

This v10 series addresses a build warning and does minor cleanups in
sd_revalidate_disk().

Changes since v9:
  - Moved the build warning fix to patch 1/3 so that it can be
    easily backported.
  - Added "Fixes:" and "Cc: stable" tags to patch 1/3 as suggested
    by Damien.
  - Moved the redundant printk removal to patch 2/3, since it is
    not a backport candidate and also removed "fixes:" tag from it as 
    it is not a bug.
  - Incorporated Reviewed-by tags from  Damien.
  - Updated changelogs accordingly.

Summary of changes:
  1. Fix excessive stack usage warning in sd_revalidate_disk() by
     replacing a large local struct with a kmalloc() allocation.
  2. Remove a redundant "out of memory" printk after kmalloc()
     failure. The page allocator already reports allocation failures.
  3. Make sd_revalidate_disk() return void, since its return value
     is unused by all callers.

Thanks for the reviews and guidance.

Abinash

Abinash Singh (3):
  scsi: sd: Fix build warning in sd_revalidate_disk()
  scsi: sd: Remove redundant printk after kmalloc failure
  scsi: sd: make sd_revalidate_disk() return void

 drivers/scsi/sd.c | 58 ++++++++++++++++++++++++-----------------------
 1 file changed, 30 insertions(+), 28 deletions(-)

-- 
2.43.0