linux-kernel - Re: [PATCH] dt-bindings: input: touchscreen: imagis: add missing minItems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5917367.DvuYhMxLoT@radijator>
Date: Mon, 25 Aug 2025 20:57:57 +0200
From: Duje Mihanović <duje@...emihanovic.xyz>
To: Conor Dooley <conor@...nel.org>
Cc: Markuss Broks <markuss.broks@...il.com>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Karel Balej <balejk@...fyz.cz>, David Wronek <david@...nlining.org>,
 phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
 linux-input@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject:
 Re: [PATCH] dt-bindings: input: touchscreen: imagis: add missing minItems

On Monday, 25 August 2025 18:42:38 Central European Summer Time Conor Dooley wrote:
> On Sun, Aug 24, 2025 at 06:12:05PM +0200, Duje Mihanović wrote:
> > The binding currently expects exactly 5 keycodes, which matches the
> > chip's theoretical maximum but probably not the number of touch keys on
> > any phone using the IST3032C. Add a minItems value of 2 to prevent
> > dt-validate complaints.
> 
> Does this mean that there are devicetrees in the wild that use < 5
> keycodes?

Indeed.

> > 
> > +  - |
> > +    #include <dt-bindings/input/linux-event-codes.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    i2c {
> > +      #address-cells = <1>;
> > +      #size-cells = <0>;
> > +      touchscreen@50 {
> > +        compatible = "imagis,ist3032c";
> > +        reg = <0x50>;
> > +        interrupt-parent = <&gpio>;
> > +        interrupts = <72 IRQ_TYPE_EDGE_FALLING>;
> > +        vdd-supply = <&ldo2>;
> > +        touchscreen-size-x = <480>;
> > +        touchscreen-size-y = <800>;
> > +        linux,keycodes = <KEY_APPSELECT>, <KEY_BACK>;
> 
> Does this really need a dedicated example? Why can't the property go
> into the existing one?

Only the IST3032C is currently known to support these keys and this is enforced
by the binding, so it wouldn't really make sense to add it to the 3038C
example.

Regards,
--
Duje