linux-kernel - Re: [PATCH v3 05/12] iio: dac: Remove redundant pm_runtime_mark_last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKzHHZ4y-lA-b5YW@kekkonen.localdomain>
Date: Mon, 25 Aug 2025 23:27:09 +0300
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Eugen Hristev <eugen.hristev@...aro.org>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	Cai Huoqing <cai.huoqing@...ux.dev>,
	Haibo Chen <haibo.chen@....com>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Marek Vasut <marek.vasut@...il.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Magnus Damm <magnus.damm@...il.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Chen-Yu Tsai <wens@...e.org>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Samuel Holland <samuel@...lland.org>,
	Francesco Dolcini <francesco@...cini.it>,
	João Paulo Gonçalves <jpaulo.silvagoncalves@...il.com>,
	Rui Miguel Silva <rmfrfs@...il.com>,
	Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>,
	Subhajit Ghosh <subhajit.ghosh@...aklogic.com>,
	Gerald Loacker <gerald.loacker@...fvision.net>,
	Andreas Klinger <ak@...klinger.de>, Crt Mori <cmo@...exis.com>,
	Waqar Hameed <waqar.hameed@...s.com>,
	Julien Stephan <jstephan@...libre.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Greg KH <gregkh@...uxfoundation.org>, Bo Liu <liubo03@...pur.com>,
	Al Viro <viro@...iv.linux.org.uk>, Sean Nyekjaer <sean@...nix.com>,
	Frank Li <Frank.Li@....com>, Han Xu <han.xu@....com>,
	Rayyan Ansari <rayyan@...ari.sh>, Gustavo Vaz <gustavo.vaz@....br>,
	Matti Vaittinen <mazziesaccount@...il.com>,
	Alexandru Ardelean <aardelean@...libre.com>,
	"Jiri Slaby (SUSE)" <jirislaby@...nel.org>,
	"Rob Herring (Arm)" <robh@...nel.org>,
	Fabrice Gasnier <fabrice.gasnier@...s.st.com>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	Olivier Moysan <olivier.moysan@...s.st.com>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	Marcelo Schmitt <marcelo.schmitt1@...il.com>,
	Vasileios Amoiridis <vassilisamir@...il.com>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Hans de Goede <hansg@...nel.org>,
	Javier Carrasco <javier.carrasco.cruz@...il.com>,
	Abhash Jha <abhashkumarjha123@...il.com>,
	chuguangqing <chuguangqing@...pur.com>,
	Shreeya Patel <shreeya.patel@...labora.com>,
	Per-Daniel Olsson <perdaniel.olsson@...s.com>,
	Barnabás Czémán <barnabas.czeman@...nlining.org>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	David Laight <david.laight@...lab.com>,
	Jakob Hauser <jahau@...ketmail.com>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	imx@...ts.linux.dev, linux-renesas-soc@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH v3 05/12] iio: dac: Remove redundant
 pm_runtime_mark_last_busy() calls

Hi Jonathan,

On Mon, Aug 25, 2025 at 04:00:23PM +0100, Jonathan Cameron wrote:
> > @@ -95,18 +95,8 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch,
> >  	if (en && dac->common->hfsel)
> >  		udelay(1);
> >  
> > -	if (!enable) {
> > -		pm_runtime_mark_last_busy(dev);
> > -		pm_runtime_put_autosuspend(dev);
> > -	}
> > -
> > -	return 0;
> > -
> > -err_put_pm:
> > -	if (enable) {
> > -		pm_runtime_mark_last_busy(dev);
> > -		pm_runtime_put_autosuspend(dev);
> > -	}
> > +err_pm_put:
> > +	pm_runtime_put_autosuspend(dev);
> 
> now the put is here, whether or not there was ever a get as the get is
> gated on enable()

Oops. I'll fix this in v4, with just this patch as the rest are merged.

-- 
Regards,

Sakari Ailus