linux-kernel - Re: [PATCH v1 0/2] Build ID mmap related fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKzeglUaXc1rFr4k@google.com>
Date: Mon, 25 Aug 2025 15:06:58 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	James Clark <james.clark@...aro.org>,
	Collin Funk <collin.funk1@...il.com>,
	"Masami Hiramatsu (Google)" <mhiramat@...nel.org>,
	Stephen Brennan <stephen.s.brennan@...cle.com>,
	Palmer Dabbelt <palmer@...belt.com>, Haibo Xu <haibo1.xu@...el.com>,
	Dmitry Vyukov <dvyukov@...gle.com>, Song Liu <song@...nel.org>,
	Thomas Falcon <thomas.falcon@...el.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 0/2] Build ID mmap related fixes

Hi Ian,

On Fri, Aug 22, 2025 at 05:00:22PM -0700, Ian Rogers wrote:
> Now that build ID mmap is the default I was seeing hangs during event
> synthesis in the perftool-testsuite_report. The hang was happening due
> to data pages giving block device file paths and opening the file to
> read a build ID was blocking in the open. In investigating this issue
> a bug in symbol-minimal was found. These 2 patches fix both issues. As
> the issues are present in v6.17-rc2, I think it would be worthwhile to
> add the patches as v6.17 fixes.

Looks good to me.  I'll add them for v6.17.

Thanks,
Namhyung

> 
> Ian Rogers (2):
>   perf symbol-minimal: Fix ehdr reading in filename__read_build_id
>   perf symbol: Add blocking argument to filename__read_build_id
> 
>  tools/perf/bench/inject-buildid.c  |  2 +-
>  tools/perf/builtin-buildid-cache.c |  8 ++--
>  tools/perf/builtin-inject.c        |  4 +-
>  tools/perf/tests/sdt.c             |  2 +-
>  tools/perf/util/build-id.c         |  4 +-
>  tools/perf/util/debuginfo.c        |  8 +++-
>  tools/perf/util/dsos.c             |  4 +-
>  tools/perf/util/symbol-elf.c       |  9 +++--
>  tools/perf/util/symbol-minimal.c   | 59 +++++++++++++++---------------
>  tools/perf/util/symbol.c           |  8 ++--
>  tools/perf/util/symbol.h           |  2 +-
>  tools/perf/util/synthetic-events.c |  2 +-
>  12 files changed, 58 insertions(+), 54 deletions(-)
> 
> -- 
> 2.51.0.rc2.233.g662b1ed5c5-goog
>