linux-kernel - Re: [PATCH v2 3/3] md: Fix the return value of mddev_stack_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c103d14a-16a2-0703-232e-774eb18f21d9@huaweicloud.com>
Date: Mon, 25 Aug 2025 09:26:39 +0800
From: Li Nan <linan666@...weicloud.com>
To: "Martin K. Petersen" <martin.petersen@...cle.com>,
 linan666@...weicloud.com
Cc: song@...nel.org, yukuai3@...wei.com, hare@...e.de, axboe@...nel.dk,
 linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
 bvanassche@....org, hch@...radead.org, filipe.c.maia@...il.com,
 yangerkun@...wei.com, yi.zhang@...wei.com
Subject: Re: [PATCH v2 3/3] md: Fix the return value of mddev_stack_new_rdev

在 2025/7/31 13:01, Martin K. Petersen 写道:
> 
>> In mddev_stack_new_rdev(), if the integrity profile check fails, it
>> returns -ENXIO, which means "No such device or address". This is
>> inaccurate and can mislead users. Change it to return -EINVAL.
> 
>> Fixes: c6e56cf6b2e7 ("block: move integrity information into queue_limits")
> 
> Returning -ENXIO predates the above commit by many, many years. Changing
> the return value might break applications which rely on the original
> behavior.
> 
> In case of a stacking failure, an appropriate message is logged and the
> function returns an errno. How is that misleading?
> 

Thanks for your review, I will delete it in v3.

-- 
Thanks,
Nan