linux-kernel - Re: [PATCH] ACPI/PCI: Fix memory leak fix in pci_acpi_preserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250825223731.GA808746@bhelgaas>
Date: Mon, 25 Aug 2025 17:37:31 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Nirmoy Das <nirmoyd@...dia.com>
Cc: linux-acpi@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
	"Rafael J . Wysocki" <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>, Vidya Sagar <vidyas@...dia.com>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI/PCI: Fix memory leak fix in pci_acpi_preserve_config

On Mon, Aug 25, 2025 at 02:46:42PM -0700, Nirmoy Das wrote:
> The pci_acpi_preserve_config() function is leaking memory by returning
> early without freeing the ACPI object on success. Fix that by always
> freeing the obj which is not needed by the caller.
> 
> Fixes: 9d7d5db8e78e ("PCI: Move PRESERVE_BOOT_CONFIG _DSM evaluation to pci_register_host_bridge()")
> Signed-off-by: Nirmoy Das <nirmoyd@...dia.com>

Applied to pci/misc for v6.18, thanks!

> ---
>  drivers/pci/pci-acpi.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
> index ddb25960ea47d..9369377725fa0 100644
> --- a/drivers/pci/pci-acpi.c
> +++ b/drivers/pci/pci-acpi.c
> @@ -122,6 +122,8 @@ phys_addr_t acpi_pci_root_get_mcfg_addr(acpi_handle handle)
>  
>  bool pci_acpi_preserve_config(struct pci_host_bridge *host_bridge)
>  {
> +	bool ret = false;
> +
>  	if (ACPI_HANDLE(&host_bridge->dev)) {
>  		union acpi_object *obj;
>  
> @@ -135,11 +137,11 @@ bool pci_acpi_preserve_config(struct pci_host_bridge *host_bridge)
>  					      1, DSM_PCI_PRESERVE_BOOT_CONFIG,
>  					      NULL, ACPI_TYPE_INTEGER);
>  		if (obj && obj->integer.value == 0)
> -			return true;
> +			ret = true;
>  		ACPI_FREE(obj);
>  	}
>  
> -	return false;
> +	return ret;
>  }
>  
>  /* _HPX PCI Setting Record (Type 0); same as _HPP */
> -- 
> 2.43.0
>