linux-kernel - Re: [PATCH next] drm/panel: jdi-lpm102a188a: Fix error code in jdi_panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aKv5tkJghj6DZQIB@stanley.mountain>
Date: Mon, 25 Aug 2025 08:50:46 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Brigham Campbell <me@...ghamcampbell.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
	Jessica Zhang <jessica.zhang@....qualcomm.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Douglas Anderson <dianders@...omium.org>,
	Diogo Ivo <diogo.ivo@...nico.ulisboa.pt>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org,
	dri-devel <dri-devel-bounces@...ts.freedesktop.org>
Subject: Re: [PATCH next] drm/panel: jdi-lpm102a188a: Fix error code in
 jdi_panel_prepare()

On Sun, Aug 24, 2025 at 12:54:41PM -0600, Brigham Campbell wrote:
> On Thu Aug 21, 2025 at 6:30 AM MDT, Dan Carpenter wrote:
> > If the mipi_dsi_dual() macro fails, the error code is stored in
> > dsi_ctx.accum_err.  Propagate that error back to the caller instead
> > of returning success as the current code does.
> >
> > Fixes: a6adf47d30cc ("drm/panel: jdi-lpm102a188a: Fix bug and clean up driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> > ---
> >  drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Good catch, Dan! Thank you for the patch. I'll try to be mindful of this
> kind of logic error in the future. Please let me know if you have other
> suggestions.
> 

Heh.  This is just static checker stuff.  https://github.com/error27/smatch
Humans are expected to have mechanical attention to detail at the
same level as a computer.  I just try to write the commit message out to
prove that I've looked at the code as well.

regards,
dan carpenter