linux-kernel - Re: [PATCH] staging: media: Use string choices helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeskiXhCYZZjOVYn=_d9Uo51RyXu=5s2yt-5FTWi1FSGQ@mail.gmail.com>
Date: Mon, 25 Aug 2025 10:24:43 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Chelsy Ratnawat <chelsyratnawat2001@...il.com>
Cc: andy@...nel.org, hansg@...nel.org, mchehab@...nel.org, 
	sakari.ailus@...ux.intel.com, gregkh@...uxfoundation.org, 
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, 
	linux-staging@...ts.linux.dev, tian.shu.qiu@...el.com, bingbu.cao@...el.com
Subject: Re: [PATCH] staging: media: Use string choices helpers

On Sun, Aug 24, 2025 at 6:07 PM Chelsy Ratnawat
<chelsyratnawat2001@...il.com> wrote:
>
> Use string_choices.h helpers instead of hard-coded strings.

>  drivers/staging/media/atomisp/pci/atomisp_compat_css20.c     | 3 ++-
>  drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c    | 5 +++--
>  drivers/staging/media/atomisp/pci/atomisp_v4l2.c             | 5 +++--
>  .../staging/media/atomisp/pci/runtime/binary/src/binary.c    | 3 ++-
>  drivers/staging/media/atomisp/pci/sh_css.c                   | 3 ++-
>  drivers/staging/media/ipu3/ipu3-css.c                        | 3 ++-
>  drivers/staging/media/ipu3/ipu3-v4l2.c                       | 5 +++--

Split to two patches — one per driver.

...


>  #include <linux/platform_device.h>
>  #include "../../include/linux/atomisp_platform.h"
>  #include "../../include/linux/atomisp_gmin_platform.h"
> +#include <linux/string_choices.h>

Please, move this to be in the group of the generic headers, i.e. in
_this_ case it's expected to be

  #include <linux/platform_device.h>
  #include <linux/string_choices.h>
  #include "../../include/linux/atomisp_platform.h"
  #include "../../include/linux/atomisp_gmin_platform.h"

...

> --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> @@ -17,6 +17,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/bits.h>
>  #include <media/v4l2-fwnode.h>
> +#include <linux/string_choices.h>

Ditto.

...

> --- a/drivers/staging/media/atomisp/pci/sh_css.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css.c
> @@ -8,6 +8,7 @@
>  #include <linux/mm.h>
>  #include <linux/slab.h>
>  #include <linux/vmalloc.h>
> +#include <linux/string_choices.h>

Prevent the order.

--
With Best Regards,
Andy Shevchenko