linux-kernel - Re: [PATCH v5 1/6] pwm: tiehrpwm: use GENMASK()/FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dithxhozx4k6n6xu7qrunsxec2wrklj2fipp3r24tlunmj7zid@vgqvfjw7onld>
Date: Mon, 25 Aug 2025 10:27:26 +0200
From: Uwe Kleine-König <ukleinek@...nel.org>
To: "Rafael V. Volkmer" <rafael.v.volkmer@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-pwm@...r.kernel.org
Subject: Re: [PATCH v5 1/6] pwm: tiehrpwm: use GENMASK()/FIELD_PREP() for
 register fields

Hello Rafael,

On Fri, Aug 22, 2025 at 01:40:24AM -0300, Rafael V. Volkmer wrote:
> Make register field definitions use GENMASK() and FIELD_PREP() across
> AQCTL, AQCSFRC, and TBCTL. This clarifies bit layout, reduces hand-rolled
> shift logic, and aligns the driver with common kernel patterns.
> 
> No functional change intended.

just a meta-comment without a deeper look into this series:

There is another series touching this driver at
https://lore.kernel.org/linux-pwm/cover.1754927682.git.u.kleine-koenig@baylibre.com/
that would be great to get some testing and that I tend to apply first
given that is contains also fixes. I guess you dind't base your series
on top of that?

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)