linux-kernel - Re: [PATCH v4 2/3] virtio-spi: Add virtio-spi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ae827e8-646a-4070-b06e-23bcd261ffcd@quicinc.com>
Date: Mon, 25 Aug 2025 16:35:58 +0800
From: Haixu Cui <quic_haixcui@...cinc.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
CC: <harald.mommer@....qualcomm.com>, <quic_msavaliy@...cinc.com>,
        <broonie@...nel.org>, <virtio-dev@...ts.linux.dev>,
        <viresh.kumar@...aro.org>, <linux-spi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <hdanton@...a.com>,
        <qiang4.zhang@...ux.intel.com>, <alex.bennee@...aro.org>,
        <quic_ztu@...cinc.com>
Subject: Re: [PATCH v4 2/3] virtio-spi: Add virtio-spi.h



On 8/20/2025 10:22 PM, Andy Shevchenko wrote:
> On Wed, Aug 20, 2025 at 04:49:43PM +0800, Haixu Cui wrote:
>> Add virtio-spi.h header for virtio SPI.
> 
> ...
> 
>> +/**
> 
> This is kernel-doc comment...
> 
>> + * struct virtio_spi_config - All config fields are read-only for the
>> + * Virtio SPI driver
> 
>> + */
> 
> ...
> 
>> +/*
>> + * @chip_select_id: chipselect index the SPI transfer used.
>> + *
> 
> But this one (besides having tons of unneeded blank lines) is not. Why is this
> inconsistency?
> 
>> + */
> 

Thank you for pointing out the inconsistency. I will update the comment 
to follow the kernel-doc format and remove the unnecessary blank lines.
This change will be reflected in the next patch version.

> ...
> 
>> +struct spi_transfer_result {
>> +#define VIRTIO_SPI_TRANS_OK	0
>> +#define VIRTIO_SPI_PARAM_ERR	1
>> +#define VIRTIO_SPI_TRANS_ERR	2
>> +	__u8 result;
>> +};
> 
> And this data type has no doc at all...
> 
Okay, will add definition for spi_tranafer_result.