linux-kernel - RE: [PATCH] arm64: dts: toshiba: tmpv7708: Add default GIC address cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <TY7PR01MB148188286DFE66C70C5770E86CD3EA@TY7PR01MB14818.jpnprd01.prod.outlook.com>
Date: Mon, 25 Aug 2025 02:04:32 +0000
From: <nobuhiro.iwamatsu.x90@...l.toshiba>
To: <krzysztof.kozlowski@...aro.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] arm64: dts: toshiba: tmpv7708: Add default GIC address
 cells

Hi Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Friday, August 22, 2025 10:34 PM
> To: iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> <nobuhiro.iwamatsu.x90@...l.toshiba>; Rob Herring <robh@...nel.org>;
> Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley
> <conor+dt@...nel.org>; linux-arm-kernel@...ts.infradead.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Subject: [PATCH] arm64: dts: toshiba: tmpv7708: Add default GIC address cells
> 
> Add missing address-cells 0 to GIC interrupt node to silence W=1
> warning:
> 
>   tmpv7708.dtsi:503.4-507.28: Warning (interrupt_map):
> /soc/pcie@...00000:interrupt-map:
>     Missing property '#address-cells' in node
> /soc/interrupt-controller@...01000, using 0 as fallback
> 
> Value '0' is correct because:
> 1. GIC interrupt controller does not have children, 2. interrupt-map property (in
> PCI node) consists of five components and
>    the fourth component "parent unit address", which size is defined by
>    '#address-cells' of the node pointed to by the interrupt-parent
>    component, is not used (=0)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Thanks for your patch.

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@...l.toshiba>

Best regards,
  Nobuhiro