linux-kernel - Re: [PATCH 6/6] gpio: gpio-ltc4283: Add support for the LTC4283 Swap Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <y6qiierd6qdzcyghzaisv3ajlt53f74hk64tomm57kqouci5k5@cgpxvsnz4jks>
Date: Mon, 25 Aug 2025 10:13:25 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: nuno.sa@...log.com, linux-hwmon@...r.kernel.org, 
	linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-doc@...r.kernel.org, Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>, 
	Jonathan Corbet <corbet@....net>, Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH 6/6] gpio: gpio-ltc4283: Add support for the LTC4283 Swap
 Controller

On Tue, Aug 19, 2025 at 02:12:51PM +0200, Linus Walleij wrote:
> Hi Nuno,
> 
> thanks for your patch!
> 
> On Thu, Aug 14, 2025 at 12:52 PM Nuno Sá via B4 Relay
> <devnull+nuno.sa.analog.com@...nel.org> wrote:
> 
> > From: Nuno Sá <nuno.sa@...log.com>
> >
> > The LTC4283 device has up to 8 pins that can be configured as GPIOs.
> >
> > Note that PGIO pins are not set as GPIOs by default so if they are
> > configured to be used as GPIOs we need to make sure to initialize them
> > to a sane default. They are set as inputs by default.
> >
> > Signed-off-by: Nuno Sá <nuno.sa@...log.com>
> (...)
> 
> Can you check if you can use gpio-regmap.c helper?
> 
> select GPIO_REGMAP
> 
> git grep devm_gpio_regmap_register
> for example drivers using this.
> 
> I think it can further cut down the code to very little.

Sure, I'll have that in mind for v2.

- Nuno Sá

> 
> Yours,
> Linus Walleij