linux-kernel - Re: [PATCH v2] iio: core: switch info_mask fields to unsigned long to match find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250825110812.63c276c5@jic23-huawei>
Date: Mon, 25 Aug 2025 11:08:12 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Junjie Cao <junjie.cao@...el.com>, linux-iio@...r.kernel.org,
 dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: core: switch info_mask fields to unsigned long
 to match find_bit helpers

On Wed, 20 Aug 2025 12:52:18 +0300
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Wed, Aug 20, 2025 at 3:48 AM Junjie Cao <junjie.cao@...el.com> wrote:
> >
> > for_each_set_bit()/find_*_bit() expect arrays of unsigned long (see
> > include/linux/find.h), but industrialio-core passed const long * into
> > iio_device_add_info_mask_type{,_avail}().
> >
> > These masks are used purely as bit arrays and are populated via BIT()
> > (1UL << n). Switch the info_mask_* fields and the corresponding function
> > parameters to unsigned long so the types match the helpers. This removes
> > sparse warnings about signedness mismatches (seen with 'make C=1'
> > CF='-Wsparse-all') without changing behavior or struct layout.
> >
> > No functional change intended.  
> 
> Thanks, this is better than v1.
> Reviewed-by: Andy Shevchenko <andy@...nel.org>
> 

Applied.

Thanks,

Jonathan