linux-kernel - Re: [PATCH v3 2/3] drm/bridge: sii9234: use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eckjfjhs35nagljcjmzjmu7q2eaewvmdzavt3u62gma5xphbzi@7jfgheo5fmqz>
Date: Mon, 25 Aug 2025 13:16:06 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Henrik Grimler <henrik@...mler.se>
Cc: Marek Szyprowski <m.szyprowski@...sung.com>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Robert Foss <rfoss@...nel.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-samsung-soc@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, replicant@...osl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/3] drm/bridge: sii9234: use dev_err_probe where
 applicable

On Sun, Aug 24, 2025 at 01:16:55PM +0200, Henrik Grimler wrote:
> In case of error during resource acquisition the driver should print
> an error message only if it is not deferred probe. Use dev_err_probe
> helper to handle this, which will also record defer probe reason for
> debugging.
> 
> Signed-off-by: Henrik Grimler <henrik@...mler.se>
> ---
> v3: add missing return in error path, spotted by Dmitry
> v2: no changes
> ---
>  drivers/gpu/drm/bridge/sii9234.c | 21 ++++++++-------------
>  1 file changed, 8 insertions(+), 13 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>


-- 
With best wishes
Dmitry