linux-kernel - Re: drm/sched/tests: Remove redundant header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <697bb91b-24ea-4830-8794-373f709aa37e@web.de>
Date: Mon, 25 Aug 2025 12:48:28 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Philipp Stanner <phasta@...nel.org>, Liao Yuanhong
 <liaoyuanhong@...o.com>, dri-devel@...ts.freedesktop.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Christian König <ckoenig.leichtzumerken@...il.com>,
 Danilo Krummrich <dakr@...nel.org>, David Airlie <airlied@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maíra Canal <mcanal@...lia.com>,
 Matthew Brost <matthew.brost@...el.com>, Maxime Ripard <mripard@...nel.org>,
 Simona Vetter <simona@...ll.ch>, Thomas Zimmermann <tzimmermann@...e.de>,
 Tvrtko Ursulin <tvrtko.ursulin@...lia.com>
Subject: Re: drm/sched/tests: Remove redundant header files

>>> The header file <linux/atomic.h> is already included on line 8. Remove the
>>> redundant include.
>>
>> You would like to omit a duplicate #include directive, don't you?

The change intention is probably clear.


>> Will a corresponding refinement become helpful for the summary phrase
>> and change description?
> 
> I don't understand what you mean. Can you elaborate?
> 
> Both patch content and description are completely fine as far as I'm concerned.

How do you think about to distinguish better between the deletion of header files
and an adjustment for a repeated preprocessor directive?

Regards,
Markus