linux-kernel - Re: [PATCH] EDAC: altera: Delete an inappropriate dma_free_coherent() call in altr_sdr_mc_err_inject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf83aab6-a9ce-4746-8d88-e66d05d8a866@kernel.org>
Date: Mon, 25 Aug 2025 05:49:27 -0500
From: Dinh Nguyen <dinguyen@...nel.org>
To: Salah Triki <salah.triki@...il.com>,
 Markus Elfring <Markus.Elfring@....de>, Borislav Petkov <bp@...en8.de>,
 Tony Luck <tony.luck@...el.com>, James Morse <james.morse@....com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Robert Richter
 <rric@...nel.org>, linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH] EDAC: altera: Delete an inappropriate dma_free_coherent()
 call in altr_sdr_mc_err_inject_write()

On 7/30/25 22:15, Salah Triki wrote:
> `dma_free_coherent()` must only be called if the corresponding
> `dma_alloc_coherent()` call has succeeded. Calling it when the allocation
> fails leads to undefined behavior.
> 
> Add a check to ensure that the memory is only freed when the allocation
> was successful.
> 
> Signed-off-by: Salah Triki <salah.triki@...il.com>
> Fixes: 71bcada88b0f3 ("edac: altera: Add Altera SDRAM EDAC support")
> Cc: Markus Elfring <Markus.Elfring@....de>
> Cc: Dinh Nguyen <dinguyen@...nel.org>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: James Morse <james.morse@....com>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: Robert Richter <rric@...nel.org>
> Cc: linux-edac@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: stable@...r.kernel.org
> ---
>   drivers/edac/altera_edac.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index cae52c654a15..7685a8550d4b 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -128,7 +128,6 @@ static ssize_t altr_sdr_mc_err_inject_write(struct file *file,
>   
>   	ptemp = dma_alloc_coherent(mci->pdev, 16, &dma_handle, GFP_KERNEL);
>   	if (!ptemp) {
> -		dma_free_coherent(mci->pdev, 16, ptemp, dma_handle);
>   		edac_printk(KERN_ERR, EDAC_MC,
>   			    "Inject: Buffer Allocation error\n");
>   		return -ENOMEM;


Acked-by: Dinh Nguyen <dinguyen@...nel.org>