linux-kernel - Re: [PATCH RFC 4/7] md/raid10: convert read/write to use bio_submit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aKxCJT6ul_WC94-x@infradead.org>
Date: Mon, 25 Aug 2025 03:59:49 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: hch@...radead.org, colyli@...nel.org, hare@...e.de, tieren@...as.com,
	axboe@...nel.dk, tj@...nel.org, josef@...icpanda.com,
	song@...nel.org, yukuai3@...wei.com, akpm@...ux-foundation.org,
	neil@...wn.name, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
	linux-raid@...r.kernel.org, yi.zhang@...wei.com,
	yangerkun@...wei.com, johnny.chenyi@...wei.com
Subject: Re: [PATCH RFC 4/7] md/raid10: convert read/write to use
 bio_submit_split()

>  		allow_barrier(conf);
> +		bio = bio_submit_split(bio, max_sectors, &conf->bio_split);
>  		wait_barrier(conf, false);
> +
> +		if (!bio) {
> +			set_bit(R10BIO_Returned, &r10_bio->state);
> +			goto err_handle;
> +		}

The NULL return should only happen for REQ_NOWAIT here, so maybe
give R10BIO_Returned a more descriptive name?  Also please document
the flag in the header.

Any maybe yhe code wants a splitting helper instead of open coding
setting this flag in multiple places?