linux-kernel - Re: [PATCH RFC 7/7] block: fix disordered IO in the case recursive split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKxD2hdsUpZrtqOy@infradead.org>
Date: Mon, 25 Aug 2025 04:07:06 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: hch@...radead.org, colyli@...nel.org, hare@...e.de, tieren@...as.com,
	axboe@...nel.dk, tj@...nel.org, josef@...icpanda.com,
	song@...nel.org, yukuai3@...wei.com, akpm@...ux-foundation.org,
	neil@...wn.name, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
	linux-raid@...r.kernel.org, yi.zhang@...wei.com,
	yangerkun@...wei.com, johnny.chenyi@...wei.com
Subject: Re: [PATCH RFC 7/7] block: fix disordered IO in the case recursive
 split

On Mon, Aug 25, 2025 at 05:37:00PM +0800, Yu Kuai wrote:
> +void submit_bio_noacct(struct bio *bio)

Maybe just have version of submit_bio_noacct that takes the split
argument, and make submit_bio_noacct a tiny wrapper around it?  That
should create less churns than this version I think.  In fact I suspect
we can actually bypass submit_bio_noacct entirely, all the checks and
accounting in it were already done when submitting the origin bio, so
the bio split helper could just call into submit_bio_noacct_nocheck 
directly.