linux-kernel - Re: [PATCH 0/3] ALSA: use vmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1e66db3-980c-4e06-98cc-021c166e9b21@vivo.com>
Date: Mon, 25 Aug 2025 19:46:11 +0800
From: Qianfeng Rong <rongqianfeng@...o.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Philipp Stanner <phasta@...nel.org>, Thorsten Blum
 <thorsten.blum@...ux.dev>, "open list:SOUND" <linux-sound@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] ALSA: use vmalloc_array() to simplify code


在 2025/8/25 19:01, Andy Shevchenko 写道:
> On Sun, Aug 24, 2025 at 09:55:09PM +0800, Qianfeng Rong wrote:
>> Remove array_size() calls and replace vmalloc() with vmalloc_array() to
>> simplify the code and maintain consistency with existing kmalloc_array()
>> usage.
>>
>> vmalloc_array() is also optimized better, resulting in less instructions
>> being used [1].
> Have you considered using sizeof(*...) where it makes sense?
I believe that sizeof(*...) should preferably not be mixed with this patch;
instead, it should be addressed in a separate, independent patch that
covers all relevant instances.

Additionally, I understand that not everyone prefers using sizeof(*...), as
it reduces readability.  What do you think, Andy?

Best regards,
Qianfeng
>