linux-kernel - Re: [PATCH net v2] phy: mscc: Fix when PTP clock is register and unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250825134709.kk3tjc3sxuyo57pw@skbuf>
Date: Mon, 25 Aug 2025 16:47:09 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, richardcochran@...il.com,
	rmk+kernel@...linux.org.uk, vadim.fedorenko@...ux.dev,
	christophe.jaillet@...adoo.fr, rosenp@...il.com,
	viro@...iv.linux.org.uk, atenart@...nel.org,
	quentin.schulz@...tlin.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] phy: mscc: Fix when PTP clock is register and
 unregister

On Mon, Aug 25, 2025 at 08:55:43AM +0200, Horatiu Vultur wrote:
> It looks like that every time when the interface was set down and up the
> driver was creating a new ptp clock. On top of this the function
> ptp_clock_unregister was never called.
> Therefore fix this by calling ptp_clock_register and initialize the
> mii_ts struct inside the probe function and call ptp_clock_unregister when
> driver is removed.
> 
> Fixes: 7d272e63e0979d ("net: phy: mscc: timestamping and PHC support")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> 
> ---
> v1->v2:
> - move implementation of __vsc8584_deinit_ptp into vsc8584_ptp_deinit
> - drop the PHY matching and check if ptp_clock is valid.
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>