linux-kernel - Re: [PATCH v3 0/3] arm64: dts: qcom: Add PCIe Support for sm8750

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175621649862.159548.14099860400165270689.robh@kernel.org>
Date: Tue, 26 Aug 2025 08:56:45 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>
Cc: Conor Dooley <conor+dt@...nel.org>, 
 Krzysztof Wilczyński <kwilczynski@...nel.org>, 
 linux-arm-msm@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Konrad Dybcio <konradybcio@...nel.org>, 
 Bjorn Andersson <andersson@...nel.org>, 
 Kishon Vijay Abraham I <kishon@...nel.org>, Vinod Koul <vkoul@...nel.org>, 
 Lorenzo Pieralisi <lpieralisi@...nel.org>, linux-pci@...r.kernel.org, 
 devicetree@...r.kernel.org, Manivannan Sadhasivam <mani@...nel.org>, 
 linux-phy@...ts.infradead.org, quic_mrana@...cinc.com, 
 quic_vbadigan@...cinc.com, linux-kernel@...r.kernel.org, 
 Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH v3 0/3] arm64: dts: qcom: Add PCIe Support for sm8750


On Tue, 26 Aug 2025 16:32:52 +0530, Krishna Chaitanya Chundru wrote:
> Describe PCIe controller and PHY. Also add required system resources like
> regulators, clocks, interrupts and registers configuration for PCIe.
> 
> The qcom_pcie_parse_ports() function currently iterates over all available
> child nodes of the PCIe controller's device tree node. This includes
> unrelated nodes such as OPP (Operating Performance Points) nodes, which do
> not contain the expected 'reset' and 'phy' properties. As a result, parsing
> fails and the driver falls back to the legacy method of parsing the
> controller node directly. However, this fallback also fails when properties
> are shifted to the root port, leading to probe failure.
> 
> Fix this by restricting the parsing logic to only consider child nodes with
> device_type = "pci", which is the expected and required property for PCIe
> ports as defined in pci-bus-common.yaml.
> 
> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>
> ---
> Changes in v3:
> - Use device_type to find pci node or not instead of node name.
> - Link to v2: https://lore.kernel.org/r/20250826-pakala-v2-0-74f1f60676c6@oss.qualcomm.com
> 
> Changes in v2:
> - Follow the x1e80100.dtsi pcie node description (Konrad).
> - define phy & perst, wake in port node as per latest bindings.
> - Add check in the driver to parse only pcie child nodes.
> - Added acked by tag(Rob).
> - Removed dtbinding and phy driver patches as they got applied.
> - Link to v1: https://lore.kernel.org/r/20250809-pakala-v1-0-abf1c416dbaa@oss.qualcomm.com
> 
> ---
> Krishna Chaitanya Chundru (3):
>       dt-bindings: PCI: qcom,pcie-sm8550: Add SM8750 compatible
>       arm64: dts: qcom: sm8750: Add PCIe PHY and controller node
>       PCI: qcom: Restrict port parsing only to pci child nodes
> 
>  .../devicetree/bindings/pci/qcom,pcie-sm8550.yaml  |   1 +
>  arch/arm64/boot/dts/qcom/sm8750.dtsi               | 180 ++++++++++++++++++++-
>  drivers/pci/controller/dwc/pcie-qcom.c             |   2 +
>  3 files changed, 182 insertions(+), 1 deletion(-)
> ---
> base-commit: b6add54ba61890450fa54fd9327d10fdfd653439
> change-id: 20250809-pakala-25a7c1ddba85
> 
> Best regards,
> --
> Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit b6add54ba61890450fa54fd9327d10fdfd653439

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250826-pakala-v3-0-721627bd5bb0@....qualcomm.com:

arch/arm64/boot/dts/qcom/sm8750-mtp.dtb: /soc@...hy@...6000: failed to match any schema with compatible: ['qcom,sm8750-qmp-gen3x2-pcie-phy']
arch/arm64/boot/dts/qcom/sm8750-qrd.dtb: /soc@...hy@...6000: failed to match any schema with compatible: ['qcom,sm8750-qmp-gen3x2-pcie-phy']