linux-kernel - Re: [PATCH] wifi: mac80211: fix incorrect type for ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eae93cc2-8090-4040-8b27-c492af528b45@oss.qualcomm.com>
Date: Tue, 26 Aug 2025 08:00:24 -0700
From: Jeff Johnson <jeff.johnson@....qualcomm.com>
To: Liao Yuanhong <liaoyuanhong@...o.com>,
        Johannes Berg <johannes@...solutions.net>,
        "open list:MAC80211" <linux-wireless@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wifi: mac80211: fix incorrect type for ret

On 8/24/2025 7:29 PM, Liao Yuanhong wrote:
> The variable ret is declared as a u32 type, but it is assigned a value
> of -EOPNOTSUPP. Since unsigned types cannot correctly represent negative
> values, the type of ret should be changed to int.

not only that, but drv_get_ftm_responder_stats() is declared to return int

> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>

Reviewed-by: Jeff Johnson <jeff.johnson@....qualcomm.com>