linux-kernel - Re: [PATCH 1/4] staging: media: atomisp: Remove unnecessary forward declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aK3MfAbTa49C8Rqo@smile.fi.intel.com>
Date: Tue, 26 Aug 2025 18:02:20 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Adrian Barnaś <abarnas@...gle.com>
Cc: Hans de Goede <hansg@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Andy Shevchenko <andy@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH 1/4] staging: media: atomisp: Remove unnecessary forward
 declarations

On Tue, Aug 26, 2025 at 10:44:11AM +0000, Adrian Barnaś wrote:
> Get rid of fifo_monitor_status_valid() and fifo_monitor_status_accept()
> forward declaration because it brings no value.

If you send more than one patch, get used to cover letter.
My script [1] does this for me, so I won't forget doing it.
Also one may use `b4 relay`.

[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

The patch series (all patches) LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>

...

> +	return (data >> (((port_id * 2) + _hive_str_mon_valid_offset))) & 0x1;

Side note, perhaps change this (in a separate followup) to

	return data & BIT(port_id * 2 + _hive_str_mon_valid_offset);

It will significantly increase readability.

...

> +	return (data >> (((port_id * 2) + _hive_str_mon_accept_offset))) & 0x1;

In the same way

	return data & BIT(port_id * 2 + _hive_str_mon_accept_offset);

-- 
With Best Regards,
Andy Shevchenko