linux-kernel - Re: [v4, net-next 5/9] bng_en: Allocate packet buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81a8ba60-d07b-42f1-a3cd-25a11c9f1f45@oracle.com>
Date: Tue, 26 Aug 2025 20:50:53 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Bhargava Marreddy <bhargava.marreddy@...adcom.com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        andrew+netdev@...n.ch, horms@...nel.org
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        michael.chan@...adcom.com, pavan.chebbi@...adcom.com,
        vsrama-krishna.nemani@...adcom.com,
        Vikas Gupta <vikas.gupta@...adcom.com>,
        Rajashekar Hudumula <rajashekar.hudumula@...adcom.com>
Subject: Re: [v4, net-next 5/9] bng_en: Allocate packet buffers



On 8/26/2025 10:14 PM, Bhargava Marreddy wrote:
> +static void bnge_alloc_one_rx_ring_netmem(struct bnge_net *bn,
> +					  struct bnge_rx_ring_info *rxr,
> +					  int ring_nr)
> +{
> +	u32 prod;
> +	int i;
> +
> +	prod = rxr->rx_agg_prod;
> +	for (i = 0; i < bn->rx_agg_ring_size; i++) {
> +		if (bnge_alloc_rx_netmem(bn, rxr, prod, GFP_KERNEL)) {
> +			netdev_warn(bn->netdev, "init'ed rx ring %d with %d/%d pages only\n",
> +				    ring_nr, i, bn->rx_ring_size);

Looks good, but would bn->rx_agg_ring_size be more accurate here instead 
of bn->rx_ring_size? since this loop is allocating the AGG ring.

> +			break;
> +		}
> +		prod = NEXT_RX_AGG(prod);
> +	}
> +	rxr->rx_agg_prod = prod;
> +}


Thanks,
Alok