linux-kernel - RE: [PATCH v2 3/5] arm64: dts: imx95-15x15-evk: Use phys to replace xceiver-supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DB9PR04MB8429631F164C8AE7571AE3CB9239A@DB9PR04MB8429.eurprd04.prod.outlook.com>
Date: Tue, 26 Aug 2025 02:19:27 +0000
From: Sherry Sun <sherry.sun@....com>
To: Peng Fan <peng.fan@....com>, Marc Kleine-Budde <mkl@...gutronix.de>,
	Vincent Mailhol <mailhol.vincent@...adoo.fr>, Vinod Koul <vkoul@...nel.org>,
	Kishon Vijay Abraham I <kishon@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Aswath Govindraju <a-govindraju@...com>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
	<kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Frank Li
	<frank.li@....com>, Bough Chen <haibo.chen@....com>
CC: "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
	"linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, Peng Fan <peng.fan@....com>
Subject: RE: [PATCH v2 3/5] arm64: dts: imx95-15x15-evk: Use phys to replace
 xceiver-supply



> -----Original Message-----
> From: Peng Fan <peng.fan@....com>
> Sent: Monday, August 25, 2025 4:37 PM
> To: Marc Kleine-Budde <mkl@...gutronix.de>; Vincent Mailhol
> <mailhol.vincent@...adoo.fr>; Vinod Koul <vkoul@...nel.org>; Kishon Vijay
> Abraham I <kishon@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof
> Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>;
> Aswath Govindraju <a-govindraju@...com>; Shawn Guo
> <shawnguo@...nel.org>; Sascha Hauer <s.hauer@...gutronix.de>;
> Pengutronix Kernel Team <kernel@...gutronix.de>; Fabio Estevam
> <festevam@...il.com>; Frank Li <frank.li@....com>; Bough Chen
> <haibo.chen@....com>
> Cc: linux-can@...r.kernel.org; linux-phy@...ts.infradead.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> imx@...ts.linux.dev; linux-arm-kernel@...ts.infradead.org; Peng Fan
> <peng.fan@....com>
> Subject: [PATCH v2 3/5] arm64: dts: imx95-15x15-evk: Use phys to replace
> xceiver-supply
> 
> The TJA1051T/3 used on i.MX95-15x15-EVK is actually high-speed CAN
> transceiver, not a regulator supply. So use phys to reflect the truth.
> 
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
> b/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
> index
> 46f6e0fbf2b09106e6e726ff8b61522d1359cfa4..f6197ba356d49b97bf7287c3f0
> f86ef84f89bac9 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
> @@ -89,12 +89,11 @@ reg_audio_switch1: regulator-audio-switch1 {
>  		gpio = <&pcal6524 0 GPIO_ACTIVE_LOW>;
>  	};
> 
> -	reg_can2_stby: regulator-can2-stby {
> -		compatible = "regulator-fixed";
> -		regulator-max-microvolt = <3300000>;
> -		regulator-min-microvolt = <3300000>;
> -		regulator-name = "can2-stby";
> -		gpio = <&pcal6524 14 GPIO_ACTIVE_LOW>;
> +	flexcan2_phy: can-phy {
> +		compatible = "nxp,tja1051", "ti,tcan1043";
> +		#phy-cells = <0>;
> +		max-bitrate = <1000000>;

Hi Peng, shouldn't the max-bitrate of TJA1051 be 5000000?

Best Regards
Sherry

> +		standby-gpios = <&pcal6524 14 GPIO_ACTIVE_HIGH>;
>  	};
> 
>  	reg_m2_pwr: regulator-m2-pwr {
> @@ -300,7 +299,7 @@ &enetc_port1 {
>  &flexcan2 {
>  	pinctrl-0 = <&pinctrl_flexcan2>;
>  	pinctrl-names = "default";
> -	xceiver-supply = <&reg_can2_stby>;
> +	phys = <&flexcan2_phy>;
>  	status = "okay";
>  };
> 
> 
> --
> 2.37.1
>