linux-kernel - Re: [PATCH v2 4/4] iio: adc: ad7124: add clock output support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aK3TlqSTo2AXbB1K@smile.fi.intel.com>
Date: Tue, 26 Aug 2025 18:32:38 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: David Lechner <dlechner@...libre.com>
Cc: Andy Shevchenko <andy.shevchenko@...il.com>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] iio: adc: ad7124: add clock output support

On Tue, Aug 26, 2025 at 10:11:09AM -0500, David Lechner wrote:
> On 8/26/25 3:13 AM, Andy Shevchenko wrote:
> > On Tue, Aug 26, 2025 at 1:55 AM David Lechner <dlechner@...libre.com> wrote:

...

> >>  static const int ad7124_master_clk_freq_hz[3] = {
> >> -       [AD7124_LOW_POWER] = 76800,
> >> -       [AD7124_MID_POWER] = 153600,
> >> -       [AD7124_FULL_POWER] = 614400,
> >> +       [AD7124_LOW_POWER] = AD7124_INT_CLK_HZ / 8,
> >> +       [AD7124_MID_POWER] = AD7124_INT_CLK_HZ / 4,
> >> +       [AD7124_FULL_POWER] = AD7124_INT_CLK_HZ,
> > 
> > Perhaps / 1 ?
> 
> Seems redundant.

Yes and no. I think that it makes sense to put for the consistency as it makes
reader aware of the divisors. 1 is also valid divisor after all.

-- 
With Best Regards,
Andy Shevchenko