[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3cca6ae2-6387-4d03-a4c5-9e2374fda687@suse.cz>
Date: Tue, 26 Aug 2025 21:45:52 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
Andrew Morton <akpm@...ux-foundation.org>
Cc: "Liam R . Howlett" <Liam.Howlett@...cle.com>, Jann Horn
<jannh@...gle.com>, Pedro Falcato <pfalcato@...e.de>,
WangYuli <wangyuli@...ontech.com>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/testing/vma: Clean up stubs in vma_internal.h
On 8/26/25 12:28, Lorenzo Stoakes wrote:
> We do not need to references arguments just to avoid compiler warnings, the
> warning in question does not arise here, so remove all of the instances of
> '(void)xxx' introduced purely to avoid this warning.
>
> As reported by WagYuli in the referenced mail, GCC 8.3 and before will have
> issues compiling this file if parameter names are not provided, so ensure
> these are always provided.
>
> Finally, perform a trivial fix up of kmem_cache_alloc() which technically
> has parameters in the incorrect order (as reported by Vlastimil Babka
> off-list).
>
> Reported-by: WangYuli <wangyuli@...ontech.com>
> Closes: https://lore.kernel.org/linux-mm/EFCEBE7E301589DE+20250729084700.208767-1-wangyuli@uniontech.com/
> Reported-by: Vlastimil Babka <vbabka@...e.cz>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Acked-by: Vlastimil Babka <vbabka@...e.cz>
Powered by blists - more mailing lists