linux-kernel - Re: [PATCH 2/7] aoe: Stop calling page_address() in free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aK4VOIlc19qb6_DQ@fedora>
Date: Tue, 26 Aug 2025 13:12:40 -0700
From: "Vishal Moola (Oracle)" <vishal.moola@...il.com>
To: Matthew Wilcox <willy@...radead.org>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Justin Sanders <justin@...aid.com>, Jens Axboe <axboe@...nel.dk>,
	linux-block@...r.kernel.org
Subject: Re: [PATCH 2/7] aoe: Stop calling page_address() in free_page()

On Tue, Aug 26, 2025 at 08:41:03PM +0100, Matthew Wilcox wrote:
> On Tue, Aug 26, 2025 at 12:32:53PM -0700, Vishal Moola (Oracle) wrote:
> > free_page() should be used when we only have a virtual address. We
> > should call __free_page() directly on our page instead.
> > 
> > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@...il.com>
> 
> Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> 
> Probably should have run ./scripts/get_maintainer.pl drivers/block/aoe/aoecmd.c
> Adding ccs.

Ah I thought I did that... seems I messed up some formatting and none of
the ccs got added :/. I'll send out a v2 later today with all the ccs
added.

> >  drivers/block/aoe/aoecmd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
> > index 6298f8e271e3..a9affb7c264d 100644
> > --- a/drivers/block/aoe/aoecmd.c
> > +++ b/drivers/block/aoe/aoecmd.c
> > @@ -1761,6 +1761,6 @@ aoecmd_exit(void)
> >  	kfree(kts);
> >  	kfree(ktiowq);
> >  
> > -	free_page((unsigned long) page_address(empty_page));
> > +	__free_page(empty_page);
> >  	empty_page = NULL;
> >  }
> > -- 
> > 2.51.0
> > 
> >